Page MenuHomePhabricator

Implement methods to store and retrieve current_user_id from database in CommCoreModule
ClosedPublic

Authored by marcin on Aug 10 2022, 5:47 AM.
Tags
None
Referenced Files
F3525582: D4794.diff
Mon, Dec 23, 5:41 PM
Unknown Object (File)
Tue, Dec 17, 6:42 AM
Unknown Object (File)
Sun, Dec 15, 10:27 PM
Unknown Object (File)
Sun, Dec 15, 10:27 PM
Unknown Object (File)
Sun, Dec 15, 10:27 PM
Unknown Object (File)
Sun, Dec 15, 10:27 PM
Unknown Object (File)
Sun, Dec 15, 10:27 PM
Unknown Object (File)
Sun, Dec 15, 10:27 PM

Details

Summary

This differential via CommCoreModule to JavaScript methods to retrieve and set current user ID that are defined and implemented in DatabaseQueryExecutor and SQLiteQueryExecutor in the parent diff.

Test Plan

Test plan is exactly the same as for parent diff with the difference that we want to call correspinding methods of global.CommCoreModule object instead of SQLiteQueryExecutor directly. This way we can be sure they work in JavaScript as well.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Add link to commit description

This revision is now accepted and ready to land.Aug 11 2022, 5:59 AM

Use database thread in current user id getter and setter

Move jsi operations from database thread to main thread

Make functions asynchronous