[native] helper for pake registration on client side
ClosedPublic
Actions

Authored by varun on Aug 10 2022, 4:33 PM.

Details

Reviewers

tomek
• karol

Commits

rCOMMfde7689b0710: [native] helper for pake registration on client side

Summary

This helper function takes the registration response from the server and completes the final step on the client side. It handles the error mapping and checking if the ClientRegistration object is present

Depends on D4799

Test Plan

Tested two diffs later in the stack

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 10 2022, 4:33 PM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptAug 10 2022, 4:33 PM

varun added a child revision: D4801: [native] helper for pake login on client side.Aug 10 2022, 4:35 PM

Harbormaster completed remote builds in B11285: Diff 15530.Aug 10 2022, 4:42 PM

varun requested review of this revision.Aug 10 2022, 4:42 PM

This diff adds huge amount of imports and doesn't use most of them. Please make sure that the diff contains only the relevant ones.

This revision is now accepted and ready to land.Aug 11 2022, 4:16 AM

In D4800#138707, @tomek wrote:

This diff adds huge amount of imports and doesn't use most of them. Please make sure that the diff contains only the relevant ones.

All of these imports are used by the end of the stack

In D4800#138812, @varun wrote:

In D4800#138707, @tomek wrote:

This diff adds huge amount of imports and doesn't use most of them. Please make sure that the diff contains only the relevant ones.

All of these imports are used by the end of the stack

Yes, I've noticed it, but it isn't a good pattern. We need to make sure that every diff which requires new imports is the one that adds them. This makes it easier to review the code and makes diffs to stand on their own.

In D4800#138819, @tomek wrote:

In D4800#138812, @varun wrote:

In D4800#138707, @tomek wrote:

This diff adds huge amount of imports and doesn't use most of them. Please make sure that the diff contains only the relevant ones.

All of these imports are used by the end of the stack

Yes, I've noticed it, but it isn't a good pattern. We need to make sure that every diff which requires new imports is the one that adds them. This makes it easier to review the code and makes diffs to stand on their own.

Agreed. I'll avoid this pattern going forward

Closed by commit rCOMMfde7689b0710: [native] helper for pake registration on client side (authored by varun). · Explain WhyAug 11 2022, 10:18 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMfde7689b0710: [native] helper for pake registration on client side.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

src/

lib.rs

56 lines

Diff 15564

View Options

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

[native] helper for pake registration on client sideClosedPublicActions