In D4800#138707, @tomek wrote:

This diff adds huge amount of imports and doesn't use most of them. Please make sure that the diff contains only the relevant ones.

All of these imports are used by the end of the stack

In D4800#138812, @varun wrote:

In D4800#138707, @tomek wrote:

This diff adds huge amount of imports and doesn't use most of them. Please make sure that the diff contains only the relevant ones.

All of these imports are used by the end of the stack

Yes, I've noticed it, but it isn't a good pattern. We need to make sure that every diff which requires new imports is the one that adds them. This makes it easier to review the code and makes diffs to stand on their own.

In D4800#138819, @tomek wrote:

In D4800#138812, @varun wrote:

In D4800#138707, @tomek wrote:

This diff adds huge amount of imports and doesn't use most of them. Please make sure that the diff contains only the relevant ones.

All of these imports are used by the end of the stack

Yes, I've noticed it, but it isn't a good pattern. We need to make sure that every diff which requires new imports is the one that adds them. This makes it easier to review the code and makes diffs to stand on their own.

Agreed. I'll avoid this pattern going forward