[Keyserver] Remove usages of nvm
Changes PlannedPublic
Actions

Authored by • jon on Aug 11 2022, 4:19 PM.

Details

Reviewers

• abosh
ashoat
atul
tomek

Summary

Usage of nvm is largely irrelevant with nix.

Remove a lot of unneeded node pinning

Test Plan

nix develop

# keyserver workflow
nix run .#mariadb-up # should only need to be done once per system boot
(cd web && yarn dev &)
(cd keyserver && yarn dev &)

# assert able get to web

Keyserver CI

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/remove-nvm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 11 2022, 4:19 PM

Herald added subscribers: atul, • adrian, tomek, ashoat. · View Herald TranscriptAug 11 2022, 4:19 PM

This isn't going to be merged anytime soon as people need to migrate over to nix, but thought I would throw up a diff

Harbormaster completed remote builds in B11326: Diff 15583.Aug 11 2022, 4:29 PM

• jon requested review of this revision.Aug 11 2022, 4:29 PM

Should link the relevant Linear issue in the diff summary whenever you put up a diff.

In terms of the current test plan, confirmed that it works for me since I did it with @jon.

However, as @ashoat noted in the Linear issue:

What would be the definition of done?
git grep nvm, no results

So if once you confirm git grep nvm returned no results (and should probably add this in the test plan), I'll accept.

Also feels good to see source-nvm.sh burn, the amount of work just to use [[ ]] instead of [ ] in that file (which we ended up not even doing, boo sh) was annoying 😂

Adding @ashoat, @atul, and @tomek as reviewers to this diff to get more eyes on it. (Feel free to change blocking status.)

This revision now requires changes to proceed.Aug 12 2022, 8:33 AM

Just going to plan changes until everyone is ready to switch