Page MenuHomePhabricator
Differential D4831

[iOS] Bump `NotificationService` `CFBundleVersion` to match parent app
ClosedPublic
Actions

Authored by atul on Aug 15 2022, 12:01 PM.
Tags
None
Referenced Files
F3241301: D4831.id15657.diff
Wed, Nov 13, 4:01 PM
Unknown Object (File)
Sun, Nov 10, 6:26 AM
Unknown Object (File)
Sat, Nov 9, 12:02 PM
Unknown Object (File)
Sat, Nov 9, 12:02 PM
Unknown Object (File)
Sat, Nov 9, 12:02 PM
Unknown Object (File)
Tue, Nov 5, 2:08 AM
Unknown Object (File)
Wed, Oct 30, 11:26 AM
Unknown Object (File)
Tue, Oct 22, 2:30 PM
View All 97 Files
Subscribers
• adrian
ashoat

Details

Reviewers
marcin
• abosh
tomek
• jacek
varun
ashoat
Commits
rCOMM7a41b3605cc6: [iOS] Bump `NotificationService` `CFBundleVersion` to match parent app
Summary

Was noticing this warning at the end of iOS builds:

warning: The CFBundleVersion of an app extension ('1') must match that of its containing parent app ('141').

This change gets rid of the warning.

Does it make a difference? Probably not.

Test Plan

Did command-line build and made sure that warning didn't appear at the end of the logs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Aug 15 2022, 12:01 PM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptAug 15 2022, 12:01 PM
atul added a comment.Aug 15 2022, 12:10 PM

(Another thing that'll be needed to bumped on each release)

Harbormaster completed remote builds in B11353: Diff 15618.Aug 15 2022, 12:12 PM
atul requested review of this revision.Aug 15 2022, 12:12 PM
ashoat accepted this revision.Aug 15 2022, 12:53 PM
This revision is now accepted and ready to land.Aug 15 2022, 12:53 PM
• abosh accepted this revision.Aug 15 2022, 1:03 PM
In D4831#139757, @atul wrote:

(Another thing that'll be needed to bumped on each release)

git grep to the rescue!

atul updated this revision to Diff 15656.Aug 16 2022, 6:50 AM

rebase before landing

This revision was landed with ongoing or failed builds.Aug 16 2022, 6:59 AM
Closed by commit rCOMM7a41b3605cc6: [iOS] Bump `NotificationService` `CFBundleVersion` to match parent app (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7a41b3605cc6: [iOS] Bump `NotificationService` `CFBundleVersion` to match parent app.
Harbormaster completed remote builds in B11381: Diff 15656.Aug 16 2022, 7:00 AM

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
8 lines

Diff 15657

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...