[Nix] Reduce services noise when doing nix develop
ClosedPublic
Actions

Authored by • jon on Aug 18 2022, 4:33 PM.

Details

Reviewers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

Summary

Avoid printing how to view logs and kill the service
when the services are already available.

In a similar spirit, only emit that it's waiting
for mariadb if it's actually waiting for mariadb.

This cuts down on every invocation of nix develop cluttering
the development workflow.

Depends on D4880

Test Plan

pkill mariadb
pkill redis

nix develop
# Should print everything

exit # leave nix shell

nix develop
# should print only print welcome message

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Owners added a reviewer: Restricted Owners Package.Aug 18 2022, 4:33 PM

• jon requested review of this revision.Aug 18 2022, 4:43 PM

This revision is okay, but the rest of the stack still needs to be addressed.

nix/mariadb-up-mac.nix
17 ↗	(On Diff #15771)
20 ↗	(On Diff #15771)
73–76 ↗	(On Diff #15771)	Darn, we really have to do the `if` statement with a `while` loop inside with both having the same condition just because of the `echo`. I wish there was a way to make this look cleaner, but it's okay!