Differential D4887

[web] Add presisting device ID
ClosedPublic
Actions

Authored by inka on Aug 19 2022, 3:22 AM.

Details

Reviewers

tomek

Commits

rCOMMef8ed1c21aac: [web] Add presisting device ID

Summary

Add persisting device ID on web.

Test Plan

Check with redux dev tools that the device ID stays the same in a different tab and after closing all the tabs and opening a new one when a user is logged in.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Aug 19 2022, 3:22 AM

Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptAug 19 2022, 3:22 AM

inka added a parent revision: D4886: [web] Add dispatching SET_DEVICE_ID action.Aug 19 2022, 3:23 AM

Harbormaster completed remote builds in B11477: Diff 15788.Aug 19 2022, 3:31 AM

inka requested review of this revision.Aug 19 2022, 3:31 AM

tomek accepted this revision.Aug 19 2022, 8:15 AM

This revision is now accepted and ready to land.Aug 19 2022, 8:15 AM

tomek added inline comments.Aug 19 2022, 8:18 AM

web/root.js
22 ↗	(On Diff #15788)	It seems like deviceIDUpdater will make it so we can just add the property to whitelist instead of increasing the version and adding a migration

Closed by commit rCOMMef8ed1c21aac: [web] Add presisting device ID (authored by • InkaSokolowska). · Explain WhyAug 25 2022, 2:35 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMMef8ed1c21aac: [web] Add presisting device ID.

inka added a child revision: D5301: Rename deviceIDTypes to deviceTypes, add comments.Oct 5 2022, 5:59 AM

Revision Contents
Changeset List

Path

Size

web/

root.js

2 lines

Diff 15961

View Options

web/root.js

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Lines	std::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);		Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);

if (!outcome.IsSuccess()) {		if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage());		throw std::runtime_error(outcome.GetError().GetMessage());
}		}

Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();		Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();

std::string result;		std::stringstream buffer;
result.resize(size);		buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1);		std::string result(buffer.str());
		std::string cpy = result;

return result;		return result;
}		}

void AwsS3Bucket::getObjectDataChunks(		void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName,		const std::string &objectName,
const std::function<void(const std::string &)> &callback,		const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const {		const size_t chunkSize) const {
Show All 16 Lines	for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome =		Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request);		getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) {		if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage());		throw std::runtime_error(getOutcome.GetError().GetMessage());
}		}

Aws::IOStream &retrievedFile =		Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody();		getOutcome.GetResultWithOwnership().GetBody();
std::string result;
		std::stringstream buffer;
		buffer << retrievedFile.rdbuf();
		std::string result(buffer.str());
result.resize(nextSize);		result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result);		callback(result);
}		}
}		}

void AwsS3Bucket::appendToObject(		void AwsS3Bucket::appendToObject(
const std::string &objectName,		const std::string &objectName,
const std::string &data) {		const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName);		const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines

[web] Add presisting device IDClosedPublicActions