Differential D4887

[web] Add presisting device ID
ClosedPublic
Actions

Authored by inka on Aug 19 2022, 3:22 AM.

Details

Reviewers

tomek

Commits

rCOMMef8ed1c21aac: [web] Add presisting device ID

Summary

Add persisting device ID on web.

Test Plan

Check with redux dev tools that the device ID stays the same in a different tab and after closing all the tabs and opening a new one when a user is logged in.

Diff Detail

Repository

rCOMM Comm

Branch

inka/redux_device_id

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 19 2022, 3:22 AM

Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptAug 19 2022, 3:22 AM

inka added a parent revision: D4886: [web] Add dispatching SET_DEVICE_ID action.Aug 19 2022, 3:23 AM

Harbormaster completed remote builds in B11477: Diff 15788.Aug 19 2022, 3:31 AM

inka requested review of this revision.Aug 19 2022, 3:31 AM

tomek accepted this revision.Aug 19 2022, 8:15 AM

This revision is now accepted and ready to land.Aug 19 2022, 8:15 AM

tomek added inline comments.Aug 19 2022, 8:18 AM

web/root.js
22	It seems like deviceIDUpdater will make it so we can just add the property to whitelist instead of increasing the version and adding a migration

Closed by commit rCOMMef8ed1c21aac: [web] Add presisting device ID (authored by • InkaSokolowska). · Explain WhyAug 25 2022, 2:35 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMMef8ed1c21aac: [web] Add presisting device ID.

inka added a child revision: D5301: Rename deviceIDTypes to deviceTypes, add comments.Oct 5 2022, 5:59 AM

Revision Contents
Changeset List

Path

Size

web/

root.js

2 lines

Diff 15788

View Options

[web] Add presisting device IDClosedPublicActions