• max retitled this revision from [services] Tunnelbroker - Add fcm crate to Cargo dependencies to [services] Tunnelbroker - Add FCM crate to Cargo dependencies.

• max edited the summary of this revision. (Show Details)

tomek accepted this revision.Aug 22 2022, 6:35 AM

tomek added a reviewer: ashoat.

• jon accepted this revision.Aug 22 2022, 9:56 AM

ashoat accepted this revision.Aug 22 2022, 2:41 PM

This revision is now accepted and ready to land.Aug 22 2022, 2:41 PM

Did we make sure the library's license doesn't have a copyleft?

In D4893#142119, @ashoat wrote:

Did we make sure the library's license doesn't have a copyleft?

Noticed that questions about dependency licenses have come up a few times.

It looks like it could be possible to automate some of this with various tools we could add to CI.

EG for NPM: https://www.npmjs.com/package/license-checker
For Rust: https://github.com/onur/cargo-license, https://embarkstudios.github.io/cargo-deny/checks/licenses/index.html

This probably wouldn't guarantee anything, but might be a good first pass to eliminate dependencies with licenses we know for certain we want to avoid.

It's MIT https://crates.io/crates/fcm, but we should probably set up a check.

Closed by commit rCOMMadf0b2a90754: [services] Tunnelbroker - Add FCM crate to Cargo dependencies (authored by • max). · Explain WhyAug 22 2022, 3:15 PM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMadf0b2a90754: [services] Tunnelbroker - Add FCM crate to Cargo dependencies.

In D4893#142119, @ashoat wrote:

Did we make sure the library's license doesn't have a copyleft?

It's MIT https://crates.io/crates/fcm, but we should probably set up a check.

Yes, seems we are ok with it.

It looks like it could be possible to automate some of this with various tools we could add to CI.
For Rust: https://github.com/onur/cargo-license, https://embarkstudios.github.io/cargo-deny/checks/licenses/index.html

That would be a good idea!

• max removed a child revision: D4807: [services] Tunnelbroker - Update CMakeLists and Cargo build with the CXX integration updates.Aug 24 2022, 5:12 PM

• max removed a child revision: D4894: [services] Tunnelbroker - Rust FCM push notifications library wrapper.Aug 29 2022, 5:48 AM