Renamed the timestamp variable names to be clearer.
Also annotated totalTime and userTime with a comment to explain the difference between them.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/input/input-state-container.react.js | ||
|---|---|---|
| 597 | Is it initial media selection time or initial media send time? Because sendTime sounds clearer to me. We don't upload files once they're selected, we upload files once they've been sent (the send button has been clicked). I think mediaSentTimestamp is clearer (but this could be vague since the message hasn't been sent yet since the media has to be uploaded). It does match selection.sendTime though. Maybe something about the send button being clicked, or something. | |
| 606–612 | Thoughts on using a multiline comment here? | |
| 610 | ||