Introduce redesigned InlineSidebar component.
Currently it receives reactios as an array of strings to simplify testing with emojis, but it the future it will problably need to receive some complex rection data type.
Details
Details
Tested text, media and robotext messages in all cases with/without sidebar or/and reactions.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jacek/inline-sidebar-web
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/chat/inline-sidebar.react.js | ||
|---|---|---|
| 19 | Using [] as a default value breaks the memoization | |
| 25–27 | We're using center as a container type, so maybe use left and right to make it more abstract? CSS doesn't care too much about viewers | |
| 47–50 | Can we use it directly instead of memoizing it? Is the memoization of this component really beneficial? | |
| 62 | We don't need to include the whole threadInfo in dependencies. Just !threadInfo is what we care about. | |
| 68 | What value is returned by useOnClickThread when threadInfo is falsy? Do we need a conditional here? | |
| 77 | Maybe use a default import instead? | |
Comment Actions
address feedback
| web/chat/inline-sidebar.react.js | ||
|---|---|---|
| 68 | useOnClickThread has invariant, so it cannot be called with falsy value: invariant( thread?.id, 'useOnClickThread should be called with threadID set', ); | |