Paths

Table of Contentst

-
docs/
-
nix_dev_env.md

Differential D4969

[Docs] Fix nix store typo
ClosedPublic
Actions

Authored by • jon on Aug 26 2022, 3:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 6, 9:07 PM

	Unknown Object (File)
	Sat, Apr 5, 4:55 AM

	Unknown Object (File)
	Fri, Apr 4, 2:09 PM

	Unknown Object (File)
	Fri, Apr 4, 2:09 PM

	Unknown Object (File)
	Fri, Apr 4, 2:09 PM

	Unknown Object (File)
	Fri, Apr 4, 2:09 PM

	Unknown Object (File)
	Fri, Apr 4, 2:09 PM

	Unknown Object (File)
	Fri, Apr 4, 2:09 PM

Subscribers

Details

Reviewers

varun
ashoat
• abosh

Commits

rCOMMcf19b66d22ba: [Docs] Fix nix store typo

Summary

Minor fix a typo. It's /nix/store/ not /nix/store-.

Test Plan

N/A

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Aug 26 2022, 3:49 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptAug 26 2022, 3:49 PM

• jon added a parent revision: D4968: [Docs] Update supported workflow information.Aug 26 2022, 3:50 PM

Harbormaster completed remote builds in B11657: Diff 16031.Aug 26 2022, 3:59 PM

• jon requested review of this revision.Aug 26 2022, 3:59 PM

• jon added a child revision: D4970: [Docs] Provide nixified version of tableplus.Aug 26 2022, 4:38 PM

ashoat accepted this revision.Aug 26 2022, 8:41 PM

This revision is now accepted and ready to land.Aug 26 2022, 8:41 PM

Rebase with changes

• abosh accepted this revision.Aug 29 2022, 11:15 AM

• abosh added inline comments.

docs/nix_dev_env.md
87 ↗	(On Diff #16082)

Harbormaster completed remote builds in B11694: Diff 16082.Aug 29 2022, 11:23 AM

Fix respective mis-spelling

Harbormaster completed remote builds in B11697: Diff 16086.Aug 29 2022, 5:02 PM

ashoat requested changes to this revision.Sep 13 2022, 2:02 PM

ashoat added inline comments.

docs/nix_dev_env.md
87 ↗	(On Diff #16086)	This section introduces more questions than it answers. For instance, "simply adding the respective toolchains to `nativeBuildInputs`" begs the question... what is `nativeBuildInputs` I think we should either simplify the language or scrap it altogether.

This revision now requires changes to proceed.Sep 13 2022, 2:02 PM

• jon planned changes to this revision.Sep 13 2022, 3:25 PM

• jon added inline comments.

docs/nix_dev_env.md
87 ↗	(On Diff #16086)	I plan to tackle this on https://github.com/divnix/nix-book/issues/21. But I can just leave off that last bit, I think This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers Is good enough for the intuition

Simplify "How Nix introduces..." section

• jon added inline comments.Sep 15 2022, 5:39 PM

docs/nix_dev_env.md
87 ↗	(On Diff #16086)	reworded the section to be simpler

Apply suggestions

Harbormaster completed remote builds in B12193: Diff 16724.Sep 15 2022, 5:46 PM

Harbormaster completed remote builds in B12194: Diff 16725.Sep 15 2022, 5:54 PM

Great!!

This revision is now accepted and ready to land.Sep 15 2022, 7:11 PM

Closed by commit rCOMMcf19b66d22ba: [Docs] Fix nix store typo (authored by • jon). · Explain WhySep 19 2022, 3:11 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMcf19b66d22ba: [Docs] Fix nix store typo.

Revision Contents
Changeset List

Path

Size

docs/

2 lines

Diff 16874

docs/nix_dev_env.md

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines