Paths

Table of Contentst

[native] Update non-viewer blockquote message container color to be base thread color
AbandonedPublic
Actions

Authored by ginsu on Sep 4 2022, 4:45 PM.

Details

Reviewers

atul
• abosh
ashoat

Summary

Linear issue: ENG-1712. Changed non-viewer blockquote message container to be base thread color as discussed in linear

Depends on D5048

Test Plan

Please refer to the following screenshots for a before and after

Please view the attached screenshots to see the before and after of the changes I implemented

Before:

Screen Shot 2022-09-05 at 8.28.06 AM.png (2×1 px, 660 KB)

After:

Screen Shot 2022-09-05 at 8.28.13 AM.png (2×1 px, 661 KB)

Diff Detail

Repository

rCOMM Comm

Branch

eng-1712-native

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 4 2022, 4:45 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 4 2022, 4:45 PM

ginsu edited the summary of this revision. (Show Details)Sep 4 2022, 4:48 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, • abosh.

ginsu attached a referenced file: F158783: Screen Shot 2022-09-05 at 8.28.13 AM.png. (Show Details)

ginsu attached a referenced file: F158782: Screen Shot 2022-09-05 at 8.28.06 AM.png. (Show Details)

Harbormaster completed remote builds in B11870: Diff 16283.Sep 4 2022, 4:55 PM

ginsu requested review of this revision.Sep 4 2022, 4:55 PM

Looks good! Super minor string interpolation thing that should be addressed before landing

native/markdown/markdown.react.js
70	I don't think we need to include `String(...)` here? I think something like this should work

This revision is now accepted and ready to land.Sep 7 2022, 9:59 PM

Resolved atuls comment on handleing null case

Harbormaster completed remote builds in B12033: Diff 16530.Sep 8 2022, 9:34 PM

atul retitled this revision from ENG-1712 [native] updated non viewer blockquote message container color to be base thread color to [native] Update non-viewer blockquote message container color to be base thread color.Sep 12 2022, 10:30 AM

atul edited the summary of this revision. (Show Details)Sep 12 2022, 6:51 PM

atul added a parent revision: D4048: [web] Replace `EnumSettingsOption` `description` prop with `statements` prop.

atul edited the summary of this revision. (Show Details)

atul added a parent revision: D5048: [native] Implement darker color tint to block quote container.

atul removed a parent revision: D4048: [web] Replace `EnumSettingsOption` `description` prop with `statements` prop.

ashoat requested changes to this revision.Sep 15 2022, 1:00 PM

ashoat added inline comments.

native/chat/inner-text-message.react.js
121 ↗	(On Diff #16530)	Let's avoid adding parameters here. Same feedback as here – `rules` should already have this bound in

This revision now requires changes to proceed.Sep 15 2022, 1:00 PM

Abandoning diff since we are going with the tinted default message background color for non-viewer blockquote and D5048 already handles this

Revision Contents
Changeset List

Path

Size

native/

chat/

inner-text-message.react.js

1 line

markdown/

markdown.react.js

9 lines

Diff 16283

View Options

native/chat/inner-text-message.react.js