Page MenuHomePhabricator
Differential D5076

[native] Increasing `pod-patch` version
ClosedPublic
Actions

Authored by • max on Sep 6 2022, 10:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:39 AM
Unknown Object (File)
Sat, Nov 9, 11:35 AM
Unknown Object (File)
Sat, Nov 9, 9:41 AM
Unknown Object (File)
Sat, Nov 9, 7:21 AM
Unknown Object (File)
Tue, Oct 29, 11:55 AM
Unknown Object (File)
Wed, Oct 16, 11:24 PM
Unknown Object (File)
Wed, Oct 16, 11:24 PM
Unknown Object (File)
Oct 10 2024, 4:47 AM
View All 96 Files
Subscribers
• abosh
ashoat
atul
• jon
tomek

Details

Reviewers
• jon
atul
ashoat
• karol
Commits
rCOMMdf1d3819d618: [native] Increasing `pod-patch` version
Summary

This diff increased a version of the pod-patch npm package which was changed to not require BSD sed for iOS build and PR from @jon.

Related Linear task: ENG-1588

Test Plan

Successfully built iOS native app.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Sep 6 2022, 10:12 AM
• max held this revision as a draft.
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 6 2022, 10:12 AM
• max edited the summary of this revision. (Show Details)Sep 6 2022, 10:15 AM
• max edited the test plan for this revision. (Show Details)
• max added reviewers: • jon, atul, ashoat.
• max added a subscriber: • jon.
• max published this revision for review.Sep 6 2022, 10:19 AM
• max edited the summary of this revision. (Show Details)
Herald added a reviewer: • karol. · View Herald TranscriptSep 6 2022, 10:19 AM
Harbormaster completed remote builds in B11933: Diff 16382.Sep 6 2022, 10:22 AM
• jon accepted this revision.Sep 6 2022, 10:51 AM

ran:

arc patch D5076
# remove /usr/bin line from `scripts/source_development_defaults.sh`
nix develop

yarn cleaninstall
cd native/ios
pod cache clean --all
pod install

open -na xcode
# built Comm workspace
• jon added a child revision: D5077: [Nix] Remove /usr/bin/ from PATH.Sep 6 2022, 11:00 AM
atul accepted this revision.Sep 7 2022, 8:34 AM

Sweet

(might've been helpful to link the patch/diff: https://github.com/geekbrother/pod-patch/commit/391fbeba1c475728e95b67b35f871518129024bf)

ashoat accepted this revision.Sep 7 2022, 9:06 AM
This revision is now accepted and ready to land.Sep 7 2022, 9:06 AM
Closed by commit rCOMMdf1d3819d618: [native] Increasing `pod-patch` version (authored by • max, committed by • jon). · Explain WhySep 7 2022, 9:24 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMdf1d3819d618: [native] Increasing `pod-patch` version.
• jon added a comment.Sep 7 2022, 9:28 AM

landed to unblock other work where PATH was causing issues.

Revision Contents
Changeset List

PathSize
native/
2 lines
8 lines

Diff 16414

View Options

native/package.json

Loading...
View Options

yarn.lock

Loading...