Page MenuHomePhabricator
Differential D5103

[Services] Update protobuf location for blob_client
ClosedPublic
Actions

Authored by • jon on Sep 9 2022, 12:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 11:27 AM
Unknown Object (File)
Tue, May 14, 11:27 AM
Unknown Object (File)
Tue, May 14, 11:27 AM
Unknown Object (File)
Tue, May 14, 11:23 AM
Unknown Object (File)
Thu, May 9, 5:24 PM
Unknown Object (File)
Thu, May 9, 5:24 PM
Unknown Object (File)
Thu, May 9, 5:24 PM
Unknown Object (File)
Apr 5 2024, 12:06 AM
View All 59 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
varun
• abosh
• karol
Commits
rCOMM63aea3159b6a: [Services] Update protobuf location for blob_client
Summary

Blob CI uses the docker workflow which was fixed, this in-repo change
was overlooked in D4998.

Depends on D5102

Test Plan
nix develop
cd service/backup/
rm -rf build && mkdir build && cd build && cmake .. && make -j

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Sep 9 2022, 12:13 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 9 2022, 12:13 PM
Harbormaster completed remote builds in B12061: Diff 16561.Sep 9 2022, 12:23 PM
• jon requested review of this revision.Sep 9 2022, 12:23 PM
atul accepted this revision.Sep 12 2022, 10:11 AM

Was able to follow Test Plan and confirm that backup service built correctly on macOS VM:

Screen Shot 2022-09-12 at 1.10.13 PM.png (1×2 px, 1 MB)

This revision is now accepted and ready to land.Sep 12 2022, 10:11 AM
Closed by commit rCOMM63aea3159b6a: [Services] Update protobuf location for blob_client (authored by • jon). · Explain WhySep 12 2022, 10:50 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM63aea3159b6a: [Services] Update protobuf location for blob_client.

Revision Contents
Changeset List

PathSize
services/
backup/
blob_client/
2 lines

Diff 16596

View Options

services/backup/blob_client/build.rs

Loading...