Paths

Table of Contentst

[Services] Remove Arc usage
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 8:05 AM.

Details

Reviewers

• max
• karol
varun
tomek
atul

Commits

rCOMM70ed8a7b9d35: [Services] Remove Arc usage

Summary

Arc allows for the release of resources to be delegated to the runtime.
However, we have a global singleton which will always be in scope, so we don't
have to worry about it needing to be dynamically released.

https://linear.app/comm/issue/ENG-1732

Test Plan

Backup CI passes

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/remove-arc

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Sep 12 2022, 8:05 AM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptSep 12 2022, 8:05 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 8:09 AM

Harbormaster failed remote builds in B12087: Diff 16588!

Remove other references to Arc

Harbormaster completed remote builds in B12088: Diff 16589.Sep 12 2022, 8:22 AM

• jon requested review of this revision.Sep 12 2022, 8:22 AM

(Resigning since I don't have the requisite Rust knowledge to review this yet)

That makes sense! We don't need an arc in lazy_static here.

This revision is now accepted and ready to land.Sep 12 2022, 11:14 AM

Closed by commit rCOMM70ed8a7b9d35: [Services] Remove Arc usage (authored by • jon). · Explain WhySep 13 2022, 12:16 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM70ed8a7b9d35: [Services] Remove Arc usage.

• jon mentioned this in D5035: [services] Rust Integration - Backup - Rust - Multiple put clients.Sep 13 2022, 12:16 PM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

get_client.rs

8 lines

put_client.rs

10 lines

Diff 16588

View Options

services/backup/blob_client/src/get_client.rs