Page MenuHomePhabricator

[services] Tunnelbroker - Updating Protobuf with new token request and token update
ClosedPublic

Authored by max on Sep 19 2022, 7:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 10:47 PM
Unknown Object (File)
Fri, Nov 8, 10:59 AM
Unknown Object (File)
Sat, Oct 26, 2:46 AM
Unknown Object (File)
Oct 16 2024, 4:02 AM
Unknown Object (File)
Oct 13 2024, 12:05 PM
Unknown Object (File)
Oct 13 2024, 2:18 AM
Unknown Object (File)
Oct 12 2024, 11:17 AM
Unknown Object (File)
Oct 9 2024, 2:32 AM

Details

Summary

This diff introduces the following updates to the protobuf file:

  • newNotifyTokenRequired of oneof protobuf request to the client to request the new notification token from the client.
  • An optional newNotifyToken field to get the new notification token from the client.

In case of the client has an expired or wrong notification token we will send a newNotifyTokenRequired message to the client and will expect that he will re-request the Get gRPC request with the newNotifyToken and the token will be updated in the database.

Related Linear task: ENG-1816

Test Plan

No tests this is a protobuf change.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max added a reviewer: tomek.

Adding generated protobuf files.

Updating with the new token request and new notify token field according to to a discussion.

max retitled this revision from [services] Tunnelbroker - Add optional field for the new notify token to [services] Tunnelbroker - Updating Protobuf with new token request and token update.Sep 21 2022, 2:54 PM
max edited the summary of this revision. (Show Details)
max removed a subscriber: karol.
max published this revision for review.Sep 21 2022, 3:00 PM

Assuming that the new token would occupy the responseMessage field in the response, this looks good to me.

This revision is now accepted and ready to land.Sep 23 2022, 4:53 AM
This revision now requires review to proceed.Sep 23 2022, 4:59 AM
This revision is now accepted and ready to land.Sep 23 2022, 5:00 AM