[services] Tunnelbroker - Updating Protobuf with new token request and token update
ClosedPublic
Actions

Authored by • max on Sep 19 2022, 7:16 AM.

Details

Reviewers

• jon
tomek
ashoat

Commits

rCOMMad2dea6d9aec: [services] Tunnelbroker - Updating Protobuf with new token request and token…

Summary

This diff introduces the following updates to the protobuf file:

newNotifyTokenRequired of oneof protobuf request to the client to request the new notification token from the client.
An optional newNotifyToken field to get the new notification token from the client.

In case of the client has an expired or wrong notification token we will send a newNotifyTokenRequired message to the client and will expect that he will re-request the Get gRPC request with the newNotifyToken and the token will be updated in the database.

Related Linear task: ENG-1816

Test Plan

No tests this is a protobuf change.

Diff Detail

Repository

rCOMM Comm

Branch

add-new-token-to-proto

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Sep 19 2022, 7:16 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 19 2022, 7:16 AM

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald Transcript

Harbormaster failed remote builds in B12276: Diff 16838!Sep 19 2022, 7:17 AM

• max edited the summary of this revision. (Show Details)Sep 19 2022, 7:21 AM

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: tomek.

Adding generated protobuf files.

Harbormaster completed remote builds in B12288: Diff 16859.Sep 19 2022, 9:05 AM

Updating with the new token request and new notify token field according to to a discussion.

• max retitled this revision from [services] Tunnelbroker - Add optional field for the new notify token to [services] Tunnelbroker - Updating Protobuf with new token request and token update.Sep 21 2022, 2:54 PM

• max edited the summary of this revision. (Show Details)

• max removed a subscriber: • karol.

Harbormaster completed remote builds in B12357: Diff 16966.Sep 21 2022, 2:56 PM

• max published this revision for review.Sep 21 2022, 3:00 PM

• max added a child revision: D5206: [services] Tunnelbroker - Update handling of the `newNotifyToken` in `Get` stream request.Sep 21 2022, 3:38 PM

Assuming that the new token would occupy the responseMessage field in the response, this looks good to me.

tomek accepted this revision.Sep 23 2022, 4:53 AM

This revision is now accepted and ready to land.Sep 23 2022, 4:53 AM

tomek added a reviewer: ashoat.Sep 23 2022, 4:59 AM

This revision now requires review to proceed.Sep 23 2022, 4:59 AM

ashoat accepted this revision.Sep 23 2022, 5:00 AM

This revision is now accepted and ready to land.Sep 23 2022, 5:00 AM