[lib] Introduce `getUploadIDsFromMediaMessageServerDBContents(...)`
ClosedPublic
Actions

Authored by atul on Sep 20 2022, 4:00 AM.

Details

Reviewers

• abosh
tomek
marcin
varun

Commits

rCOMMca407f743999: [lib] Introduce `getUploadIDsFromMediaMessageServerDBContents(...)`

Summary

Introduce getUploadIDsFromMediaMessageServerDBContents(...) and consume in fetchUploadsForMessage(...) and assignMessageContainerToMedia(...).

Simple refactor to reduce redundant code.

Addresses feedback from @ashoat here: https://phab.comm.dev/D5087#inline-33653

Test Plan

Simple refactor, things continue to work as expected when sending media messages. Set breakpoints and ensured that values at each step were as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Sep 20 2022, 4:00 AM

atul mentioned this in D5087: [keyserver] Introduce `assignMessageContainerToMedia(...)` in `upload-updaters`.Sep 20 2022, 4:01 AM

atul retitled this revision from [lib] Introduce `getUploadIDsFromMediaMessageServerDBContents` to [lib] Introduce `getUploadIDsFromMediaMessageServerDBContents(...)`.

Harbormaster completed remote builds in B12307: Diff 16895.Sep 20 2022, 4:10 AM

atul requested review of this revision.Sep 20 2022, 4:10 AM

atul added 1 blocking reviewer(s): tomek.Sep 20 2022, 4:22 AM

tomek accepted this revision.Sep 21 2022, 7:28 AM

This revision is now accepted and ready to land.Sep 21 2022, 7:28 AM

rebase before landing

This revision was landed with ongoing or failed builds.Sep 21 2022, 12:53 PM

Closed by commit rCOMMca407f743999: [lib] Introduce `getUploadIDsFromMediaMessageServerDBContents(...)` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMca407f743999: [lib] Introduce `getUploadIDsFromMediaMessageServerDBContents(...)`.

Harbormaster completed remote builds in B12352: Diff 16956.Sep 21 2022, 1:02 PM