Paths

Table of Contentst

Differential D5195

[keyserver] Construct `MULTIMEDIA` message media correctly in `rawMessageInfoFromRows(...)`
ClosedPublic
Actions

Authored by atul on Sep 20 2022, 8:46 AM.

Tags

None

Referenced Files

	F1668389: D5195.id16963.diff
	Fri, Apr 26, 7:56 PM

	Unknown Object (File)
	Mon, Apr 15, 3:48 PM

	Unknown Object (File)
	Fri, Apr 12, 3:26 AM

	Unknown Object (File)
	Wed, Apr 10, 12:15 AM

	Unknown Object (File)
	Mon, Apr 1, 7:19 AM

	Unknown Object (File)
	Thu, Mar 28, 1:29 PM

	Unknown Object (File)
	Thu, Mar 28, 1:29 PM

	Unknown Object (File)
	Thu, Mar 28, 1:29 PM

View All 72 Files

Subscribers

Details

Reviewers

tomek
marcin
• abosh

Commits

rCOMM4e78512591e4: [keyserver] Construct `MULTIMEDIA` message media correctly in…

Summary

Use the constructMediaFromMediaMessageContentsAndUploadRows(...) function introduced in previous diff (D5193) to correctly construct MULTIMEDIA message media with mediaMessageContents and upload table rows.

Depends on D5193

Test Plan

Set breakpoints and ensured that values were as expected at each step. Logged out and back into app and observed that thumbnail information was properly retrieved and as expected in Redux store.

Diff Detail

Repository

Branch

arcpatch-D5195 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Sep 20 2022, 8:46 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 20 2022, 8:46 AM

Harbormaster completed remote builds in B12325: Diff 16917.Sep 20 2022, 8:57 AM

atul requested review of this revision.Sep 20 2022, 8:57 AM

atul added a child revision: D5197: [lib] Implement `messageContentForServerDB` for `messageTypes.MULTIMEDIA`.Sep 20 2022, 9:38 AM

tomek accepted this revision.Sep 21 2022, 6:44 AM

This revision is now accepted and ready to land.Sep 21 2022, 6:44 AM

rebase before landing

This revision was landed with ongoing or failed builds.Sep 21 2022, 1:51 PM

Closed by commit rCOMM4e78512591e4: [keyserver] Construct `MULTIMEDIA` message media correctly in… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4e78512591e4: [keyserver] Construct `MULTIMEDIA` message media correctly in….

Harbormaster completed remote builds in B12355: Diff 16962.Sep 21 2022, 1:55 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

message-fetchers.js

16 lines

Diff 16962

keyserver/src/fetchers/message-fetchers.js

Loading...