[services] Identity - Adding the generated protobuf files
ClosedPublic
Actions

Authored by • max on Sep 21 2022, 3:08 PM.

Details

Reviewers

• jon
varun

Commits

rCOMMf80170b1af8a: [services] Identity - Adding the generated protobuf files

Summary

We have updated the protobuf file for the Identity service but forgot to include the generated ones.
This diff fixes the issue where on every native build the updated headers are generated and are different from what we have in a repo.

Test Plan

Services and native build succeeded.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Sep 21 2022, 3:08 PM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 21 2022, 3:08 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max edited the summary of this revision. (Show Details)Sep 21 2022, 3:11 PM

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: varun.

• max published this revision for review.Sep 21 2022, 3:16 PM

Harbormaster completed remote builds in B12358: Diff 16967.Sep 21 2022, 3:18 PM

ah thanks. do we actually use these files anywhere though?

This revision is now accepted and ready to land.Sep 21 2022, 10:37 PM

In D5205#152866, @varun wrote:

ah thanks. do we actually use these files anywhere though?

Searching by the codebase says no, but they are generating anyways.

Closed by commit rCOMMf80170b1af8a: [services] Identity - Adding the generated protobuf files (authored by • max). · Explain WhySep 23 2022, 2:02 PM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMf80170b1af8a: [services] Identity - Adding the generated protobuf files.

Revision Contents
Changeset List

Path

Size

shared/

protos/

_generated/

identity.pb.h

identity.pb.cc

Diff 17069

View Options

shared/protos/_generated/identity.pb.h