Page MenuHomePhabricator

[native] Display thumbnail in `Multimedia` component for videos
ClosedPublic

Authored by atul on Sep 22 2022, 8:58 AM.
Tags
None
Referenced Files
F3377354: D5216.diff
Wed, Nov 27, 5:23 AM
Unknown Object (File)
Sat, Nov 23, 4:45 PM
Unknown Object (File)
Sat, Nov 23, 2:35 PM
Unknown Object (File)
Sat, Nov 23, 1:36 PM
Unknown Object (File)
Tue, Nov 12, 6:34 PM
Unknown Object (File)
Oct 28 2024, 3:23 AM
Unknown Object (File)
Oct 8 2024, 8:35 AM
Unknown Object (File)
Oct 8 2024, 8:34 AM
Subscribers

Details

Summary

Now that we have the persistence and retrieval of video thumbnails figured out, we need to actually display them in the native app.

In this diff we just retrieve the thumbnailURI instead of uri from mediaInfo for media of type video.

This enables a minimally viable end-to-end video experience.

NOTE: Still need to take a closer look at the reportURIDisplayed(...) logic and understand what's going on there better before landing this diff.
Test Plan

See video:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 22 2022, 9:04 AM
Harbormaster failed remote builds in B12388: Diff 17004!
atul requested review of this revision.Sep 22 2022, 9:09 AM
atul planned changes to this revision.Sep 22 2022, 9:26 AM
atul requested review of this revision.Sep 22 2022, 9:50 AM
atul requested review of this revision.Sep 22 2022, 4:43 PM
This revision is now accepted and ready to land.Sep 23 2022, 8:29 AM