Page MenuHomePhabricator

[services][identity] address some nits
ClosedPublic

Authored by varun on Sep 22 2022, 12:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 6:28 AM
Unknown Object (File)
Sun, Feb 2, 10:18 PM
Unknown Object (File)
Jan 27 2025, 3:20 AM
Unknown Object (File)
Jan 27 2025, 3:20 AM
Unknown Object (File)
Jan 27 2025, 3:20 AM
Unknown Object (File)
Jan 27 2025, 3:20 AM
Unknown Object (File)
Jan 27 2025, 3:18 AM
Unknown Object (File)
Dec 28 2024, 12:14 AM

Details

Summary

changed into()s to to_string()s for clarity

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 22 2022, 12:26 PM
Harbormaster failed remote builds in B12389: Diff 17005!

undo changes to constants since they're already `static by default

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 22 2022, 12:43 PM
Harbormaster failed remote builds in B12390: Diff 17006!
This revision is now accepted and ready to land.Sep 23 2022, 5:57 AM
This revision was automatically updated to reflect the committed changes.