Details

Reviewers

tomek
atul

Commits

rCOMM6d086aed72b2: Use GlobalDbSingleton API on Android to update database in reponse to notifs in…

Summary

We use GlobalDBSingleton API in Java for two things: 1. Safely update database from CommNotificationsHandler.

Test Plan

Build the app, send notifications and rescinds. Ensure app is not crashing.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Sep 27 2022, 5:48 AM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptSep 27 2022, 5:48 AM

marcin added a parent revision: D5236: Implement JNI Helper for GlobalDBSingleton.Sep 27 2022, 5:50 AM

Harbormaster completed remote builds in B12459: Diff 17106.Sep 27 2022, 5:58 AM

marcin requested review of this revision.Sep 27 2022, 5:58 AM

looks fine to me, but haven't used java in 10+ years.

tomek accepted this revision.Sep 28 2022, 4:08 AM

This revision is now accepted and ready to land.Sep 28 2022, 4:08 AM

Redefine API

marcin retitled this revision from Use GlobalDbSingleton API on Android to update database in reponse to notifs in CommNotificationsHandler and to eagerly enable multithreading when app is launched to Use GlobalDbSingleton API on Android to update database in reponse to notifs in CommNotificationsHandler..Oct 5 2022, 2:59 AM

marcin edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B12616: Diff 17340.Oct 5 2022, 3:08 AM

Fix compilation bug

Harbormaster completed remote builds in B12622: Diff 17346.Oct 5 2022, 3:25 AM

tomek accepted this revision.Oct 6 2022, 7:23 AM

Rebase before landing

Harbormaster completed remote builds in B12670: Diff 17406.Oct 7 2022, 2:45 AM

Closed by commit rCOMM6d086aed72b2: Use GlobalDbSingleton API on Android to update database in reponse to notifs in… (authored by marcin). · Explain WhyOct 7 2022, 2:51 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM6d086aed72b2: Use GlobalDbSingleton API on Android to update database in reponse to notifs in….