Page MenuHomePhabricator
Differential D5249

[web] Disable 'Delete' button for threads when the password input is empty
ClosedPublic
Actions

Authored by rohan on Sep 28 2022, 10:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 9:45 AM
Unknown Object (File)
Tue, Nov 5, 9:45 AM
Unknown Object (File)
Tue, Nov 5, 9:45 AM
Unknown Object (File)
Tue, Nov 5, 9:45 AM
Unknown Object (File)
Tue, Nov 5, 9:45 AM
Unknown Object (File)
Tue, Nov 5, 9:45 AM
Unknown Object (File)
Tue, Nov 5, 9:43 AM
Unknown Object (File)
Sep 27 2024, 2:36 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
• jakub
ginsu
Commits
rCOMM48f285ac58e8: [web] Disable 'Delete' button for threads when the password input is empty
Summary

Added a check in the disabled property of the delete button to
check if there is an password entered into the input field - if not,
disable the button.

Test Plan

Tested on web and it works as expected. Handled cases where the
modal is opened for the first time, and also when a password is deleted.
The button remains disabled whenever the input is empty.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Sep 28 2022, 10:12 AM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptSep 28 2022, 10:12 AM
rohan edited the test plan for this revision. (Show Details)Sep 28 2022, 10:13 AM
rohan attached a referenced file: F184802: ENG-1913.mov. (Show Details)Sep 28 2022, 10:15 AM
Harbormaster completed remote builds in B12496: Diff 17151.Sep 28 2022, 10:20 AM
rohan requested review of this revision.Sep 28 2022, 10:20 AM
atul added a reviewer: ginsu.Sep 28 2022, 10:45 AM
ginsu requested changes to this revision.Sep 28 2022, 10:54 AM
ginsu added inline comments.
web/modals/threads/settings/thread-settings-delete-tab.react.js
113 ↗(On Diff #17151)

Nit: I personally would write the case like this, but would love to hear what the other reviewers think

This revision now requires changes to proceed.Sep 28 2022, 10:54 AM
rohan added inline comments.Sep 29 2022, 9:59 AM
web/modals/threads/settings/thread-settings-delete-tab.react.js
113 ↗(On Diff #17151)

I'm happy to change it to that - might make evaluation more consistent as opposed to checking with`!`

rohan updated this revision to Diff 17199.Sep 29 2022, 10:02 AM

Update the way it checks for no password

Harbormaster completed remote builds in B12534: Diff 17199.Sep 29 2022, 10:12 AM
rohan updated this revision to Diff 17200.Sep 29 2022, 10:13 AM

Fix formatting

rohan updated this revision to Diff 17201.Sep 29 2022, 10:17 AM

Final (hopefully) fix on formatting

Harbormaster completed remote builds in B12535: Diff 17200.Sep 29 2022, 10:23 AM
Harbormaster completed remote builds in B12536: Diff 17201.Sep 29 2022, 10:27 AM
ginsu accepted this revision.Sep 29 2022, 11:47 AM

sweet solid stuff

atul accepted this revision.Sep 29 2022, 11:53 AM

looks good, thanks for taking a first pass @ginsu

This revision is now accepted and ready to land.Sep 29 2022, 11:53 AM
Closed by commit rCOMM48f285ac58e8: [web] Disable 'Delete' button for threads when the password input is empty (authored by rohan). · Explain WhySep 29 2022, 11:56 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM48f285ac58e8: [web] Disable 'Delete' button for threads when the password input is empty.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
settings/
4 lines

Diff 17206

View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...