[keyserver] Update importJSON to use fs instead of import
ClosedPublic
Actions

Authored by rohan on Sep 29 2022, 12:44 PM.

Details

Reviewers

atul
ashoat
ginsu

Commits

rCOMM3850cd7a6cd7: [keyserver] Update importJSON to use fs instead of import

Summary

Replace the await import(../../${path}) syntax in importJSON to
use fs.readFileSync instead.

This addresses: https://linear.app/comm/issue/ENG-1182/update-importjson-to-use-fs-instead-of-import

Context: https://linear.app/comm/issue/ENG-929/fix-issues-with-node-1614-import-syntax-assertions

Test Plan

The local instance of Comm remains running and does not crash
with these new changes. Also ran flow in the keyserver directory to
ensure that it was fine to remove the $FlowFixMe comment.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Sep 29 2022, 12:44 PM

Herald added subscribers: • abosh, tomek. · View Herald TranscriptSep 29 2022, 12:45 PM

rohan edited the summary of this revision. (Show Details)Sep 29 2022, 12:45 PM

rohan edited the summary of this revision. (Show Details)Sep 29 2022, 12:51 PM

Harbormaster completed remote builds in B12541: Diff 17208.Sep 29 2022, 12:55 PM

rohan requested review of this revision.Sep 29 2022, 12:55 PM

ashoat accepted this revision.Sep 29 2022, 1:09 PM

Looks good, but before landing can you include a console.log with a descriptive error message in the catch block?

This revision is now accepted and ready to land.Sep 30 2022, 6:11 AM

Add a descriptive console.log message when catching an error

Harbormaster completed remote builds in B12560: Diff 17243.Sep 30 2022, 7:05 AM

Closed by commit rCOMM3850cd7a6cd7: [keyserver] Update importJSON to use fs instead of import (authored by rohan). · Explain WhySep 30 2022, 7:06 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM3850cd7a6cd7: [keyserver] Update importJSON to use fs instead of import.

ashoat mentioned this in D5371: [keyserver] Update assets.json imports to use fs instead of import.Oct 14 2022, 8:38 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

import-json.js

9 lines

Diff 17247

View Options

keyserver/src/utils/import-json.js

[keyserver] Update importJSON to use fs instead of importClosedPublicActions