Paths

Table of Contentst

Differential D5271

[web] modified InlineSidebar container width to fix horizontal scrolling in ChatMessageList
ClosedPublic
Actions

Authored by ginsu on Sep 30 2022, 6:31 PM.

Tags

None

Referenced Files

	F187427: Screen Shot 2022-09-30 at 2.25.51 PM.png
	Sep 30 2022, 6:35 PM

	F187426: Screen Shot 2022-09-30 at 2.24.53 PM.png
	Sep 30 2022, 6:35 PM

	F187425: Screen Shot 2022-09-30 at 2.01.18 PM.png
	Sep 30 2022, 6:35 PM

	F187424: Screen Shot 2022-09-30 at 1.58.07 PM.png
	Sep 30 2022, 6:35 PM

	F187428: Screen Recording 2022-09-30 at 11.51.24 AM.mov
	Sep 30 2022, 6:35 PM

Subscribers

Details

Reviewers

atul
• abosh
rohan
michal

Commits

rCOMM52f334a925b3: [web] modified InlineSidebar container width to fix horizontal scrolling in…

Summary

modified InlineSidebar container with margin-left and margin-right properties to get the correct container width and get rid of horizontal scrolling in ChatMesssageList

Linear Task: ENG-1911

Test Plan

Please view the screenshots to see how the InlineSidebar width was changed. Please note that the red border is just there to highlight the change and is not part of the changes. Additionally, to test the no scrolling of the ChatMessageList go to a Chat that has a thread in it. Try scrolling left and right, and you should not be able to do it, which is the expected behavior.

Before:

Screen Shot 2022-09-30 at 1.58.07 PM.png (1×3 px, 192 KB)

After:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 30 2022, 6:31 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 30 2022, 6:31 PM

ginsu edited the summary of this revision. (Show Details)Sep 30 2022, 6:35 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, • abosh, rohan, michal.

ginsu edited the summary of this revision. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu attached a referenced file: F187427: Screen Shot 2022-09-30 at 2.25.51 PM.png. (Show Details)Sep 30 2022, 6:39 PM

ginsu attached a referenced file: F187426: Screen Shot 2022-09-30 at 2.24.53 PM.png. (Show Details)

ginsu attached a referenced file: F187425: Screen Shot 2022-09-30 at 2.01.18 PM.png. (Show Details)

ginsu attached a referenced file: F187424: Screen Shot 2022-09-30 at 1.58.07 PM.png. (Show Details)

ginsu attached a referenced file: F187428: Screen Recording 2022-09-30 at 11.51.24 AM.mov. (Show Details)

Harbormaster completed remote builds in B12565: Diff 17251.Sep 30 2022, 6:41 PM

ginsu requested review of this revision.Sep 30 2022, 6:41 PM

I can confirm that this fixes the issue for me!

atul accepted this revision.Oct 3 2022, 7:45 PM

This revision is now accepted and ready to land.Oct 3 2022, 7:45 PM

Pulled this diff down locally and I'm not getting any horizontal scroll bars, nice find on the cause!

Closed by commit rCOMM52f334a925b3: [web] modified InlineSidebar container width to fix horizontal scrolling in…. · Explain WhyOct 3 2022, 7:59 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM52f334a925b3: [web] modified InlineSidebar container width to fix horizontal scrolling in….

Revision Contents
Changeset List

Path

Size

web/

chat/

inline-sidebar.css

2 lines

Diff 17303

web/chat/inline-sidebar.css

Loading...