Page MenuHomePhabricator

[web] Notifications dialog - change name
ClosedPublic

Authored by michal on Oct 3 2022, 2:20 AM.
Tags
None
Referenced Files
F2017990: D5279.diff
Sat, Jun 15, 6:06 PM
Unknown Object (File)
Fri, Jun 14, 6:41 AM
Unknown Object (File)
Mon, Jun 3, 9:59 AM
Unknown Object (File)
Mon, Jun 3, 8:08 AM
Unknown Object (File)
Fri, May 24, 8:04 AM
Unknown Object (File)
Fri, May 24, 8:04 AM
Unknown Object (File)
Fri, May 24, 8:04 AM
Unknown Object (File)
May 8 2024, 1:16 AM
Subscribers

Details

Summary

ENG-1729
Changes notifications dialog title for sidebars from "Channel notifications" to "Thread notifications".

Test Plan

Test if the title is correct for sidebars and non-sidebars.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal requested review of this revision.Oct 3 2022, 2:31 AM
ashoat added inline comments.
web/modals/threads/notifications/notifications-modal.react.js
94 ↗(On Diff #17278)

Let's use threadIsSidebar for this. This will be slightly more convenient for us if we ever introduce a second kind of sidebar

This revision is now accepted and ready to land.Oct 3 2022, 6:13 AM

Use threadIsSidebar, rebase