[web] Notifications dialog - disable background option
ClosedPublic
Actions

Authored by michal on Oct 3 2022, 2:24 AM.

Details

Reviewers

tomek
atul
• abosh

Commits

rCOMMaac8661cb799: [web] Notifications dialog - disable background option

Summary

ENG-1729
Disables background option in notifications dialog for sidebars, because they can't be moved between tabs anyway.

Test Plan

Check that nothing changed for non-sidebars. Check that there is no radio button for Background options and it can't be selected for sidebars.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Oct 3 2022, 2:24 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 3 2022, 2:24 AM

michal edited the summary of this revision. (Show Details)Oct 3 2022, 2:24 AM

michal added a parent revision: D5279: [web] Notifications dialog - change name.

michal added a child revision: D5281: [web] Notifications dialog - add text.Oct 3 2022, 2:32 AM

Harbormaster completed remote builds in B12577: Diff 17279.Oct 3 2022, 2:33 AM

michal requested review of this revision.Oct 3 2022, 2:33 AM

atul accepted this revision.Oct 3 2022, 2:25 PM

This revision is now accepted and ready to land.Oct 3 2022, 2:25 PM

Closed by commit rCOMMaac8661cb799: [web] Notifications dialog - disable background option (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyOct 5 2022, 5:06 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMaac8661cb799: [web] Notifications dialog - disable background option.

Revision Contents
Changeset List

Path

Size

web/

components/

enum-settings-option.react.js

25 lines

modals/

threads/

notifications/

notifications-modal.react.js

3 lines

Diff 17352

View Options

web/components/enum-settings-option.react.js