Disable reporting own messages
ClosedPublic
Actions

Authored by inka on Oct 3 2022, 3:40 AM.

Details

Reviewers

tomek
michal
• abosh

Commits

rCOMMfcf24f684f8e: Disable reporting own messages

Summary

Related: ENG-1915, D5109,
We don't want users to see 'Report' option in tooltip for their own messages

Test Plan

See that pressing a text message/long pressing a multimedia message that the user sent shows a tooltip without the 'Report' option, but doing the same to a message sent by a different user shows a
toolitp that includes this option.

Diff Detail

Repository

rCOMM Comm

Branch

inka/disable_reporting_own_mess

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Oct 3 2022, 3:40 AM

Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptOct 3 2022, 3:40 AM

inka edited the summary of this revision. (Show Details)Oct 3 2022, 3:40 AM

inka added a reviewer: • abosh.

Harbormaster completed remote builds in B12580: Diff 17283.Oct 3 2022, 3:50 AM

inka requested review of this revision.Oct 3 2022, 3:50 AM

Does the order of elements in actions array makes a difference? If that's the case, we should keep the order.

This revision now requires changes to proceed.Oct 3 2022, 5:15 AM

@tomek the order doesn't matter. We pass to tooltip visibleEntryIDs and tooltipSpec and it displays entries obtained from tooltipSpec.entries.filter(entry => visibleSet.has(entry.id)); so they will always be in the order specified in tooltipSpec.

In D5282#155706, @inka wrote:

@tomek the order doesn't matter. We pass to tooltip visibleEntryIDs and tooltipSpec and it displays entries obtained from tooltipSpec.entries.filter(entry => visibleSet.has(entry.id)); so they will always be in the order specified in tooltipSpec.

Thanks for explaining!

As a side note, please request review when answering questions without putting up a new revision. Otherwise the diff doesn't appear in my queue.

This revision is now accepted and ready to land.Oct 3 2022, 6:55 AM

I see, thank you for bringing this to my attention!

Rebase

Harbormaster completed remote builds in B12590: Diff 17310.Oct 4 2022, 12:30 AM

Closed by commit rCOMMfcf24f684f8e: Disable reporting own messages (authored by • InkaSokolowska). · Explain WhyOct 4 2022, 12:32 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMMfcf24f684f8e: Disable reporting own messages.