Paths

Table of Contentst

Differential D5296

[landing] updated layout of team members wrapper
ClosedPublic
Actions

Authored by ginsu on Oct 4 2022, 2:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 26, 5:02 PM

	Unknown Object (File)
	Tue, Nov 26, 5:02 PM

	Unknown Object (File)
	Mon, Nov 25, 10:31 PM

	Unknown Object (File)
	Sun, Nov 24, 12:25 PM

	Unknown Object (File)
	Sun, Nov 24, 12:53 AM

	Unknown Object (File)
	Tue, Nov 19, 5:21 AM

	Unknown Object (File)
	Tue, Nov 19, 12:25 AM

	Unknown Object (File)
	Sat, Nov 9, 8:09 PM

Subscribers

Details

Reviewers

atul
ashoat
rohan
• abosh

Commits

rCOMMbf0b0753e1d8: [landing] updated layout of team members wrapper

Summary

updated layout of team member wrapper by doubling the row-gap property and adding a max-width

Linear Task: ENG-1506

Depends: D5295

Test Plan

Please review the screenshots to see the before and after of the changes I made:

Before:

Screen Shot 2022-10-04 at 4.47.12 PM.png (2×3 px, 3 MB)

After:

Please note for this image I added the red border just to highlight the size of max-width:

Screen Shot 2022-10-04 at 5.13.19 PM.png (1×3 px, 3 MB)

Screen Shot 2022-10-04 at 5.14.14 PM.png (2×3 px, 3 MB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 4 2022, 2:11 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 4 2022, 2:11 PM

ginsu edited the summary of this revision. (Show Details)Oct 4 2022, 2:16 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, ashoat, rohan, • abosh.

ginsu attached a referenced file: F190650: Screen Shot 2022-10-04 at 5.14.14 PM.png. (Show Details)

ginsu attached a referenced file: F190647: Screen Shot 2022-10-04 at 5.13.19 PM.png. (Show Details)

ginsu attached a referenced file: F190648: Screen Shot 2022-10-04 at 4.47.12 PM.png. (Show Details)

Harbormaster completed remote builds in B12606: Diff 17330.Oct 4 2022, 2:20 PM

ginsu requested review of this revision.Oct 4 2022, 2:20 PM

atul accepted this revision.Oct 4 2022, 6:28 PM

This revision is now accepted and ready to land.Oct 4 2022, 6:28 PM

Definite improvement. Have we checked with various browsers and various resolutions / screen formats?

Definitely looks better!

In D5296#156166, @ashoat wrote:

Definite improvement. Have we checked with various browsers and various resolutions / screen formats?

Yup! I thought everything looked okay when I tested initially, but here are some screenshots on several different devices, if you want to double-check:

On bigger screen/monitor:

Screen Shot 2022-10-05 at 9.29.26 AM.png (3×5 px, 6 MB)

On iPad Air:

Screen Shot 2022-10-05 at 9.30.53 AM.png (3×5 px, 3 MB)

On iPhone 12:

Screen Shot 2022-10-05 at 9.31.12 AM.png (3×5 px, 2 MB)

ginsu attached a referenced file: F191517: Screen Shot 2022-10-05 at 9.31.12 AM.png. (Show Details)Oct 5 2022, 6:35 AM

ginsu attached a referenced file: F191515: Screen Shot 2022-10-05 at 9.30.53 AM.png. (Show Details)

ginsu attached a referenced file: F191512: Screen Shot 2022-10-05 at 9.29.26 AM.png. (Show Details)

Looks great!! Thanks for checking :)

Closed by commit rCOMMbf0b0753e1d8: [landing] updated layout of team members wrapper (authored by ginsu). · Explain WhyOct 6 2022, 7:06 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMbf0b0753e1d8: [landing] updated layout of team members wrapper.

Revision Contents
Changeset List

Path

Size

landing/

3 lines

Diff 17385

landing/team.css

Loading...