Page MenuHomePhabricator
Differential D5443

[native] add yarn clean-rust to native
ClosedPublic
Actions

Authored by varun on Oct 20 2022, 9:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 3:40 PM
Unknown Object (File)
Fri, Apr 18, 11:05 AM
Unknown Object (File)
Fri, Apr 18, 7:45 AM
Unknown Object (File)
Fri, Apr 18, 3:05 AM
Unknown Object (File)
Thu, Apr 17, 12:37 PM
Unknown Object (File)
Sat, Apr 12, 8:51 PM
Unknown Object (File)
Wed, Apr 9, 3:40 AM
Unknown Object (File)
Wed, Apr 9, 3:40 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM8cce03d7293f: [native] add yarn clean-rust to native
Summary

Some build artifacts for native now live in the native_rust_library subdirectory. We should have a yarn script to remove these artifacts, and we should also invoke this script from the yarn clean script.

Related issue: https://linear.app/comm/issue/ENG-2091/android-local-build-failure

Test Plan

cd native && yarn clean

verified that the target subdirectory was removed

Diff Detail

Repository
rCOMM Comm
Branch
clean-rust
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 20 2022, 9:41 AM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 20 2022, 9:41 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 9:43 AM
Harbormaster failed remote builds in B12938: Diff 17738!
ashoat mentioned this in D5437: [native] remove `grpc_client` folder on `clean-commoncpp` script.Oct 20 2022, 9:53 AM
varun updated this revision to Diff 17743.Oct 20 2022, 10:40 AM

handle case where cargo isn't available

Harbormaster completed remote builds in B12942: Diff 17743.Oct 20 2022, 10:49 AM
varun requested review of this revision.Oct 20 2022, 10:49 AM
atul accepted this revision.Oct 20 2022, 11:14 AM
This revision is now accepted and ready to land.Oct 20 2022, 11:14 AM
ashoat added a comment.Oct 20 2022, 11:23 AM

handle case where cargo isn't available

Thanks, this is critical to make sure we don't break eg. keyserver deploys

Closed by commit rCOMM8cce03d7293f: [native] add yarn clean-rust to native (authored by varun). · Explain WhyOct 20 2022, 12:45 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM8cce03d7293f: [native] add yarn clean-rust to native.

Revision Contents
Changeset List

PathSize
native/
3 lines

Diff 17738

View Options

native/package.json

  • This file was added.
This file contains generated code, which does not normally need to be reviewed. Show File Contents