Page MenuHomePhabricator
Differential D5446

[native] Rename MarkdownLinkContext to MarkdownContext
ClosedPublic
Actions

Authored by rohan on Oct 20 2022, 12:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 10:07 PM
Unknown Object (File)
Thu, May 2, 10:07 PM
Unknown Object (File)
Thu, May 2, 10:06 PM
Unknown Object (File)
Thu, May 2, 10:06 PM
Unknown Object (File)
Thu, May 2, 10:06 PM
Unknown Object (File)
Thu, May 2, 10:05 PM
Unknown Object (File)
Thu, May 2, 8:24 PM
Unknown Object (File)
Mar 31 2024, 7:06 AM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
ginsu
• abosh
Commits
rCOMM63126dde46bb: [native] Rename MarkdownLinkContext to MarkdownContext
Summary

This is Step 1 of ENG-2072
(https://linear.app/comm/issue/ENG-2072/maintain-the-spoiler-state-upon-opening-textmessagetooltipmodal).
In this diff, we rename MarkdownLinkContext to just MarkdownContext in
order to (in a later step of this task) make this Context usable for the
spoilers and so we only need one Provider. Depends on D5383

Test Plan

The app runs the same as it did prior to these changes, and
tested to see that link markdown behaves the same as before.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Oct 20 2022, 12:06 PM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 20 2022, 12:06 PM
rohan added a reviewer: • abosh.Oct 20 2022, 12:18 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 12:23 PM
Harbormaster failed remote builds in B12944: Diff 17746!
Harbormaster completed remote builds in B12944: Diff 17746.Oct 20 2022, 12:29 PM
rohan requested review of this revision.Oct 20 2022, 12:29 PM
ginsu accepted this revision.Oct 20 2022, 1:33 PM

looks good

atul accepted this revision.Oct 21 2022, 1:11 PM

Sweet! Perfect example of simple rename diff, makes subsequent diffs far less noisy

This revision is now accepted and ready to land.Oct 21 2022, 1:11 PM
rohan added a child revision: D5515: [native] Update the existing Context API for Markdown to encompass AppNavigator.Nov 1 2022, 9:14 AM
rohan updated this revision to Diff 18280.Nov 9 2022, 10:06 AM

Rebase and resolve conflicts

Harbormaster completed remote builds in B13329: Diff 18280.Nov 9 2022, 10:20 AM
rohan updated this revision to Diff 19033.Nov 30 2022, 12:18 PM

Rebase (pending testing since my dev environment isn't working properly
again)

rohan updated this revision to Diff 19034.Nov 30 2022, 12:22 PM

Keep markdown-link-context.react.js deleted

Harbormaster completed remote builds in B13893: Diff 19033.Nov 30 2022, 12:31 PM
Harbormaster completed remote builds in B13894: Diff 19034.Nov 30 2022, 12:34 PM
Closed by commit rCOMM63126dde46bb: [native] Rename MarkdownLinkContext to MarkdownContext (authored by rohan). · Explain WhyNov 30 2022, 2:48 PM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM63126dde46bb: [native] Rename MarkdownLinkContext to MarkdownContext.

Revision Contents
Changeset List

Diff 18280

View Options

native/chat/text-message.react.js

Loading...
View Options

native/markdown/markdown-context.js

Loading...
View Options

native/markdown/markdown-link-context.js

Loading...
View Options

native/markdown/markdown-link.react.js

Loading...