[web] focus search input for thread picker modal
ClosedPublic
Actions

Authored by ginsu on Oct 24 2022, 1:36 PM.

Details

Reviewers

atul
rohan
ashoat

Commits

rCOMM7a361f32bad4: [web] focus search input for thread picker modal

Summary

The search input in the Thread Picker Modal now focuses whenever the thread picker opens up. This saves the user a click and is what we do on native

Linear Task: ENG-2051

Test Plan

Please watch the demos to see the changes I made. Please note that only the Search component in the Thread Picker Modal has this focus change, and other places that use the Search components will remain the same

Before:

After:

Diff Detail

Repository

rCOMM Comm

Branch

eng-2051

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 24 2022, 1:36 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 24 2022, 1:36 PM

ginsu edited the summary of this revision. (Show Details)Oct 24 2022, 1:42 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, rohan.

ginsu attached a referenced file: F207183: Screen Recording 2022-10-24 at 4.29.34 PM.mov. (Show Details)

ginsu attached a referenced file: F207182: Screen Recording 2022-10-24 at 4.12.41 PM.mov. (Show Details)

Harbormaster completed remote builds in B13020: Diff 17880.Oct 24 2022, 1:49 PM

ginsu requested review of this revision.Oct 24 2022, 1:49 PM

ashoat requested changes to this revision.Oct 24 2022, 2:09 PM

ashoat added inline comments.

web/components/search.react.js
49–54	Great idea forwarding the ref!
web/modals/threads/thread-picker-modal.react.js
76	You should never use an effect without specifying a dep list. In this case, you're causing the field to focus on every single render. If you mean to only do it in `componentDidMount`, you should provide an empty dep list instead (`[]`)