Page MenuHomePhabricator

[Nix] Provide iOS specific dev shell
AbandonedPublic

Authored by jon on Oct 25 2022, 11:49 AM.
Tags
None
Referenced Files
F3507014: D5478.diff
Fri, Dec 20, 7:01 PM
Unknown Object (File)
Sat, Dec 7, 10:49 PM
Unknown Object (File)
Tue, Nov 26, 5:20 PM
Unknown Object (File)
Tue, Nov 26, 5:20 PM
Unknown Object (File)
Sun, Nov 24, 11:07 PM
Unknown Object (File)
Sun, Nov 24, 11:07 PM
Unknown Object (File)
Oct 26 2024, 9:41 PM
Unknown Object (File)
Oct 26 2024, 9:41 PM

Details

Reviewers
varun
atul
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

iOS build environment is very different to native (architecture)
development. Namely, the tooling and ecosystems surroudning iOS generally
require the macOS defaults for tooling.

Instead of trying to get a consistent nix environment across all workflows,
give macOS the space it desires.

https://linear.app/comm/issue/ENG-1948
https://linear.app/comm/issue/ENG-1947

related: https://linear.app/comm/issue/ENG-1837

Test Plan

Follow test plan from next diff for more through testing

nix develop .#ios

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 25 2022, 11:49 AM
atul requested changes to this revision.Oct 26 2022, 7:37 AM

Follow test plan from next diff for more through testing

Test plan for following diff (D5479) failed in my local environment.. passing back to your queue. Let me know if I'm missing something/there's some additional steps I need to take to get things to work

This revision now requires changes to proceed.Oct 26 2022, 7:37 AM
atul requested changes to this revision.Oct 26 2022, 2:47 PM

Worked for me in local environment.

Can we move the shell script to its own file? If not let me know and I'll accept as is.

This revision now requires changes to proceed.Oct 26 2022, 2:47 PM

going to shelve this later for https://linear.app/comm/issue/ENG-1837, and do a more holistic refactoring of the different parts of the shells including the shell hook.