Page MenuHomePhabricator
Differential D5499

[native] Introduce `StaffContext`
ClosedPublic
Actions

Authored by atul on Oct 28 2022, 12:46 PM.
Tags
None
Referenced Files
F1712979: D5499.diff
Tue, May 7, 6:01 AM
Unknown Object (File)
Mar 28 2024, 4:58 AM
Unknown Object (File)
Mar 28 2024, 4:58 AM
Unknown Object (File)
Mar 28 2024, 4:58 AM
Unknown Object (File)
Mar 28 2024, 4:58 AM
Unknown Object (File)
Mar 28 2024, 4:58 AM
Unknown Object (File)
Mar 28 2024, 4:57 AM
Unknown Object (File)
Mar 28 2024, 4:51 AM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
marcin
tomek
varun
ashoat
Commits
rCOMM5f0effca4743: [native] Introduce `StaffContext`
Summary

Context: https://linear.app/comm/issue/ENG-2134/have-a-flag-that-indicates-whether-the-build-is-a-staff-release

This diff is essentially copy/paste of native/root-context.js (which is why I made it a separate diff)

Depends on D5498

Test Plan

NA

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Oct 28 2022, 12:46 PM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptOct 28 2022, 12:46 PM
atul edited the summary of this revision. (Show Details)Oct 28 2022, 12:47 PM
atul published this revision for review.Oct 28 2022, 12:54 PM
atul planned changes to this revision.
atul updated this revision to Diff 17969.Oct 28 2022, 12:56 PM

stage

atul planned changes to this revision.Oct 28 2022, 12:56 PM
Harbormaster completed remote builds in B13090: Diff 17968.Oct 28 2022, 1:00 PM
Harbormaster completed remote builds in B13091: Diff 17969.Oct 28 2022, 1:09 PM
ashoat accepted this revision.Oct 28 2022, 1:34 PM
ashoat added inline comments.
native/staff/staff-context.js
9 ↗(On Diff #17969)

Possibly to split this line into two to maintain 80-char columns? Not sure if Prettier is forcing it or not

atul updated this revision to Diff 18000.Oct 31 2022, 1:23 PM

reduce line width to be < 80

This revision is now accepted and ready to land.Oct 31 2022, 1:23 PM
atul added inline comments.Oct 31 2022, 1:24 PM
native/staff/staff-context.js
9 ↗(On Diff #17969)

It's forced to a single line as written.

I can't remove the React.Context<StaffContextType> annotation because we're exporting StaffContext, but we can remove the annotation (?) on React.createContext to get line width to 76.

atul updated this revision to Diff 18001.Oct 31 2022, 1:26 PM

rebase before landing

This revision was landed with ongoing or failed builds.Oct 31 2022, 1:28 PM
Closed by commit rCOMM5f0effca4743: [native] Introduce `StaffContext` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM5f0effca4743: [native] Introduce `StaffContext`.
Harbormaster completed remote builds in B13112: Diff 18000.Oct 31 2022, 1:36 PM
Harbormaster completed remote builds in B13113: Diff 18001.Oct 31 2022, 1:39 PM

Revision Contents
Changeset List

PathSize
native/
staff/
13 lines

Diff 18002

View Options

native/staff/staff-context.js

Loading...