Page MenuHomePhabricator
Differential D5501

Revert "[native] Add calling setDeviceID from js"
AbandonedPublicDraft
Actions

Authored by inka on Oct 31 2022, 12:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 4:22 AM
Unknown Object (File)
Wed, Apr 9, 4:21 AM
Unknown Object (File)
Wed, Apr 9, 4:21 AM
Unknown Object (File)
Sun, Apr 6, 10:18 PM
Unknown Object (File)
Mar 15 2025, 9:31 PM
Unknown Object (File)
Mar 6 2025, 2:12 PM
Unknown Object (File)
Mar 5 2025, 4:44 AM
Unknown Object (File)
Mar 5 2025, 4:44 AM
View All 100 Files
Subscribers
• abosh

Details

Reviewers
ashoat
tomek
atul
varun
Summary

This reverts commit ea7addf88f6f097873eea2d91a50fa367a84c0d4. Doing this because CI faild

Test Plan

I run ios simulator

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 31 2022, 12:18 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 31 2022, 12:18 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 31 2022, 12:32 AM
Harbormaster failed remote builds in B13093: Diff 17979!
inka abandoned this revision.Nov 2 2022, 1:20 AM

Revision Contents
Changeset List

PathSize
native/
data/
sensitive-data-cleaner.react.js
sensitive-data-handler.react.js
12 lines
4 lines

Diff 17979

View Options

native/data/sensitive-data-cleaner.react.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

native/data/sensitive-data-handler.react.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

native/root.react.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;