Page MenuHomePhabricator
Differential D5505

Revert "Refactor some SQLiteQueryExecutor code"
AbandonedPublicDraft
Actions

Authored by inka on Oct 31 2022, 1:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 9:31 PM
Unknown Object (File)
Mar 8 2025, 7:45 AM
Unknown Object (File)
Mar 4 2025, 10:51 AM
Unknown Object (File)
Mar 4 2025, 10:50 AM
Unknown Object (File)
Mar 4 2025, 10:43 AM
Unknown Object (File)
Jan 16 2025, 8:43 AM
Unknown Object (File)
Jan 16 2025, 8:36 AM
Unknown Object (File)
Dec 14 2024, 7:50 AM
View All 95 Files
Subscribers
• abosh

Details

Reviewers
ashoat
tomek
varun
atul
• jon
Summary

This reverts commit 9fb642cd69620c129969d0fc8f7a761d7a56c5a5.

Test Plan

The test is pushing to phabricator and seeing if CI fails

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 31 2022, 1:34 AM
Herald added a reviewer: • jon. · View Herald TranscriptOct 31 2022, 1:34 AM
Herald added a subscriber: • abosh. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 31 2022, 1:42 AM
Harbormaster failed remote builds in B13097: Diff 17983!
inka abandoned this revision.Nov 2 2022, 1:21 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
4 lines
3 lines
34 lines

Diff 17983

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines