[native] Update @react-navigation/drawer libdef for React Nav 6
ClosedPublic
Actions

Authored by ashoat on Nov 4 2022, 10:20 AM.

Details

Reviewers

Commits

Summary

See D5537 and ENG-2175 for context. Will describe changes and where they came from inline.

Depends on D5537

Test Plan

Flow

Repository

rCOMM Comm

Branch

ashoat/react-navigation-drawer

Lint

No Lint Coverage

Unit

No Test Coverage

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2022, 10:29 AM

Add headerShown

I referenced the TypeScript types when writing this diff.

You only need to review the drawer libdef, as the others are copy-pasted from there.

native/flow-typed/npm/@react-navigation/drawer_v6.x.x.js
745 ↗	(On Diff #18091)	This was changed in React Nav 6
1974–2004 ↗	(On Diff #18091)	Some of these are new options migrated from `drawerContentOptions` in React Nav 6 Some of these got their name changed at some point prior to React Nav 6. I found the new names via API docs and TypeScript types
1994–1995 ↗	(On Diff #18091)	These were removed in React Nav 6
2005 ↗	(On Diff #18091)	New property here in React Nav 6, details here
2045–2058 ↗	(On Diff #18091)	These were migrated to options in React Nav 6
2069 ↗	(On Diff #18091)	React Nav 6 removes this
2069 ↗	(On Diff #18091)	TypeScript types only have these three props. Upgrade notes only mention removing one prop, so the others were probably removed earlier and the libdef is probably just out of date
2071 ↗	(On Diff #18091)	New property here in React Nav 6, details here
2073–2086 ↗	(On Diff #18091)	Most of these props were moved to options at some point – you can see them in the TypeScript types. React Nav 6 upgrade docs don't mention this, so presumably the change occurred earlier
2082 ↗	(On Diff #18091)	React Nav 6 moves this to options
2297 ↗	(On Diff #18091)	This was changed in React Nav 6