Page MenuHomePhabricator
Differential D5543

Run SQLite queries in parallel in SQLiteContextProvider
ClosedPublic
Actions

Authored by marcin on Nov 7 2022, 8:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 7:52 AM
Unknown Object (File)
Fri, Nov 22, 7:45 AM
Unknown Object (File)
Tue, Nov 19, 8:55 PM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
atul
tomek
ashoat
Commits
rCOMM47d92cee06af: Run SQLite queries in parallel in SQLiteContextProvider
Summary

This differential enables SQLite queries to run in parallel.

Test Plan

Build app and launch it.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2130
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 7 2022, 8:28 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 7 2022, 8:28 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 8:39 AM
Harbormaster failed remote builds in B13219: Diff 18143!
marcin updated this revision to Diff 18148.Nov 7 2022, 9:25 AM

Rebase to master to resolve android build failure

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 9:28 AM
Harbormaster failed remote builds in B13224: Diff 18148!
marcin updated this revision to Diff 18195.Nov 8 2022, 7:06 AM

Rebase master to retrigger CI

marcin added a child revision: D5545: Introduce messages field in MessageStore during rehydration.Nov 8 2022, 7:10 AM
Harbormaster completed remote builds in B13260: Diff 18195.Nov 8 2022, 7:20 AM
marcin requested review of this revision.Nov 8 2022, 7:20 AM
ashoat accepted this revision.Nov 8 2022, 8:29 AM

Short-circuiting review here... I reviewed this approach extensively with @marcin during our 1:1 yesterday and in the comments of ENG-2135, so I think it's good to land.

This revision is now accepted and ready to land.Nov 8 2022, 8:29 AM
marcin updated this revision to Diff 18245.Nov 9 2022, 12:59 AM

Rebase before landing

Harbormaster completed remote builds in B13300: Diff 18245.Nov 9 2022, 1:13 AM
Closed by commit rCOMM47d92cee06af: Run SQLite queries in parallel in SQLiteContextProvider (authored by marcin). · Explain WhyNov 9 2022, 1:30 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM47d92cee06af: Run SQLite queries in parallel in SQLiteContextProvider.

Revision Contents
Changeset List

PathSize
native/
data/
6 lines

Diff 18143

View Options

native/data/sqlite-context-provider.js

Loading...