[landing] added argument to SIWE webview message
ClosedPublic
Actions

Authored by • derek on Nov 10 2022, 9:29 AM.

Details

Reviewers

atul
ginsu
varun
ashoat

Commits

rCOMMacde9ed66e4e: [landing] added argument to SIWE webview message

Summary

it was silly not to include this from the start - turns out it's easier to verify server-side when we pass the whole message along, not just the signature

Test Plan

n/a?

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• derek created this revision.Nov 10 2022, 9:29 AM

Herald added a subscriber: • abosh. · View Herald TranscriptNov 10 2022, 9:29 AM

• derek edited the summary of this revision. (Show Details)Nov 10 2022, 9:30 AM

Harbormaster completed remote builds in B13365: Diff 18324.Nov 10 2022, 9:43 AM

• derek requested review of this revision.Nov 10 2022, 9:43 AM

• derek mentioned this in D5603: [keyserver/types] SIWE endpoint: types & native server call.Nov 10 2022, 11:41 AM

@ashoat once this lands, i'll ping you to deploy landing

ashoat accepted this revision.Nov 10 2022, 1:40 PM

This revision is now accepted and ready to land.Nov 10 2022, 1:40 PM

Closed by commit rCOMMacde9ed66e4e: [landing] added argument to SIWE webview message (authored by • derek). · Explain WhyNov 10 2022, 1:43 PM

This revision was automatically updated to reflect the committed changes.

• derek added a commit: rCOMMacde9ed66e4e: [landing] added argument to SIWE webview message.

Revision Contents
Changeset List

Path

Size

landing/

siwe.react.js

2 lines

Diff 18353

View Options

landing/siwe.react.js

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines	"dependencies": {
"firebase-admin": "^10.1.0",		"firebase-admin": "^10.1.0",
"geoip-lite": "^1.4.0",		"geoip-lite": "^1.4.0",
"invariant": "^2.2.4",		"invariant": "^2.2.4",
"landing": "0.0.1",		"landing": "0.0.1",
"lib": "0.0.1",		"lib": "0.0.1",
"lodash": "^4.17.21",		"lodash": "^4.17.21",
"multer": "^1.4.1",		"multer": "^1.4.1",
"mysql2": "^1.5.1",		"mysql2": "^1.5.1",
"node-schedule": "^1.3.0",		"node-schedule": "^2.1.0",
"nodemailer": "^6.6.1",		"nodemailer": "^6.6.1",
"react": "17.0.2",		"react": "17.0.2",
"react-dom": "17.0.2",		"react-dom": "17.0.2",
"react-html-email": "^3.0.0",		"react-html-email": "^3.0.0",
"react-redux": "^7.1.1",		"react-redux": "^7.1.1",
"react-router": "^5.2.0",		"react-router": "^5.2.0",
"redis": "^3.1.1",		"redis": "^3.1.1",
"redux": "^4.0.4",		"redux": "^4.0.4",
Show All 29 Lines

[landing] added argument to SIWE webview messageClosedPublicActions