[landing] added argument to SIWE webview message
ClosedPublic
Actions

Authored by • derek on Nov 10 2022, 9:29 AM.

Tags

None

Referenced Files

	F4108105: D5598.id18324.diff
	Mon, Feb 17, 3:37 PM

	F4108104: D5598.id18353.diff
	Mon, Feb 17, 3:37 PM

	F4108095: D5598.id.diff
	Mon, Feb 17, 3:36 PM

	F4108084: D5598.diff
	Mon, Feb 17, 3:33 PM

	Unknown Object (File)
	Sat, Feb 8, 7:30 PM

	Unknown Object (File)
	Sat, Feb 8, 7:30 PM

	Unknown Object (File)
	Sat, Feb 8, 7:30 PM

	Unknown Object (File)
	Sat, Feb 8, 7:30 PM

Subscribers

Details

Reviewers

atul
ginsu
varun
ashoat

Commits

rCOMMacde9ed66e4e: [landing] added argument to SIWE webview message

Summary

it was silly not to include this from the start - turns out it's easier to verify server-side when we pass the whole message along, not just the signature

Test Plan

n/a?

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• derek created this revision.Nov 10 2022, 9:29 AM

Herald added a subscriber: • abosh. · View Herald TranscriptNov 10 2022, 9:29 AM

• derek edited the summary of this revision. (Show Details)Nov 10 2022, 9:30 AM

Harbormaster completed remote builds in B13365: Diff 18324.Nov 10 2022, 9:43 AM

• derek requested review of this revision.Nov 10 2022, 9:43 AM

• derek mentioned this in D5603: [keyserver/types] SIWE endpoint: types & native server call.Nov 10 2022, 11:41 AM

@ashoat once this lands, i'll ping you to deploy landing

ashoat accepted this revision.Nov 10 2022, 1:40 PM

This revision is now accepted and ready to land.Nov 10 2022, 1:40 PM

Closed by commit rCOMMacde9ed66e4e: [landing] added argument to SIWE webview message (authored by • derek). · Explain WhyNov 10 2022, 1:43 PM

This revision was automatically updated to reflect the committed changes.

• derek added a commit: rCOMMacde9ed66e4e: [landing] added argument to SIWE webview message.

Revision Contents
Changeset List

Path

Size

landing/

siwe.react.js

2 lines

Diff 18353

View Options

[landing] added argument to SIWE webview messageClosedPublicActions