Paths

Table of Contentst

-
native/android/app/
-
android/
-
app/
2/4
CMakeLists.txt
-
shared/cmake/
-
cmake/
2/4
corrosion-cxx.cmake

[native] Avoid hardcoding path to rust_native_library lib.rs.h file
ClosedPublic
Actions

Authored by ashoat on Nov 10 2022, 12:41 PM.

Details

Reviewers

varun
• jon
• max

Commits

rCOMMf7a17e3c25fa: [native] Avoid hardcoding path to rust_native_library lib.rs.h file

Summary

In D5480 we hardcoded a path to this that ended up changing in a later version of React Native. This diff updates the code so the path is passed directly from corrosion-cxx.cmake to where it's consumed.

Test Plan

I tested an Android debug build on both current master and my React Native upgrade branch and it worked

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 10 2022, 12:41 PM

Herald added subscribers: • abosh, atul, tomek. · View Herald TranscriptNov 10 2022, 12:41 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 10 2022, 12:42 PM

Harbormaster failed remote builds in B13376: Diff 18338!

Address CMake Lint

Harbormaster completed remote builds in B13378: Diff 18347.Nov 10 2022, 1:29 PM

ashoat requested review of this revision.Nov 10 2022, 1:29 PM

varun accepted this revision.Nov 10 2022, 1:32 PM

This revision is now accepted and ready to land.Nov 10 2022, 1:32 PM

Closed by commit rCOMMf7a17e3c25fa: [native] Avoid hardcoding path to rust_native_library lib.rs.h file (authored by ashoat). · Explain WhyNov 10 2022, 1:39 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf7a17e3c25fa: [native] Avoid hardcoding path to rust_native_library lib.rs.h file.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

CMakeLists.txt

2 lines

shared/

cmake/

corrosion-cxx.cmake

15 lines

Diff 18351

View Options

native/android/app/CMakeLists.txt

This file was added.

				div.containerViewerLiked {
				padding: 4px;
				border-radius: 4px;
				background-color: var(--shades-black-80);
				}

				div.container:hover {
				cursor: pointer;
				}
				tomekUnsubmitted Not Done Inline Actions For other tooltip actions we don't need to manually set this style. Can we use the mechanism we already have, or are there any reasons for not doing so? tomek: For other tooltip actions we don't need to manually set this style. Can we use the mechanism we…
				ginsuAuthorUnsubmitted Done Inline Actions I believe the other icons don't need to set this style because it is built into `IcomoonReact`. When I switched the Like action tooltip button with one of the icons the hover style just works out of the box. Wondering if @atul has more context since he is pretty familiar with the icons stuff ginsu: I believe the other icons don't need to set this style because it is built into `IcomoonReact`.
				tomekUnsubmitted Not Done Inline Actions It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they could be used in other places - not only as buttons. It seems like the style on hover is applied in `message-tooltip.css` div.messageActionButtons svg:hover { cursor: pointer; color: var(--fg); } so it should be enough to apply this style also to the new button. tomek: It wouldn't make too much sense for `Icomoon` to provide hover effects for icons because they…
				ginsuAuthorUnsubmitted Done Inline Actions Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes ginsu: Ahhhhh that makes sense, thank you for clarifying, I will make the necessary changes