Page MenuHomePhabricator
Differential D5656

[Nix] Default value of ANDROID_HOME
ClosedPublic
Actions

Authored by • jon on Nov 16 2022, 3:04 PM.
Tags
None
Referenced Files
F3522010: D5656.diff
Mon, Dec 23, 5:33 AM
Unknown Object (File)
Sun, Dec 15, 6:23 AM
Unknown Object (File)
Sun, Dec 15, 6:23 AM
Unknown Object (File)
Sun, Dec 15, 6:23 AM
Unknown Object (File)
Sun, Dec 15, 6:23 AM
Unknown Object (File)
Sun, Dec 15, 6:19 AM
Unknown Object (File)
Tue, Nov 26, 5:34 AM
Unknown Object (File)
Sun, Nov 24, 11:53 AM
View All Files
Subscribers
• abosh
tomek

Details

Reviewers
atul
ashoat
varun
Commits
rCOMM7413dab98cda: [Nix] Default value of ANDROID_HOME
Summary

Prefer to use ANDROID_HOME as it's the new canonical way to describe
the installation path of the Android SDK. Also alias the value to
ANDROID_SDK_ROOT for compatibility with certain tools such as sdkmanager.

https://linear.app/comm/issue/ENG-2274

Test Plan
nix develop

echo $ANDROID_HOME
echo $ANDROID_SDK_ROOT # should match, and point to sdk installation

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D5656
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Nov 16 2022, 3:04 PM
Herald added subscribers: • abosh, tomek. · View Herald TranscriptNov 16 2022, 3:04 PM
Harbormaster completed remote builds in B13496: Diff 18504.Nov 16 2022, 3:15 PM
• jon requested review of this revision.Nov 16 2022, 3:15 PM
ashoat added inline comments.Nov 16 2022, 3:15 PM
scripts/source_development_defaults.sh
17 ↗(On Diff #18504)

Typo: "the" shouldn't be there

ashoat accepted this revision.Nov 16 2022, 3:16 PM
This revision is now accepted and ready to land.Nov 16 2022, 3:16 PM
• jon updated this revision to Diff 18537.Nov 17 2022, 10:47 AM
• jon marked an inline comment as done.

Remove extra "the"

Harbormaster completed remote builds in B13525: Diff 18537.Nov 17 2022, 11:01 AM
• jon updated this revision to Diff 18543.Nov 17 2022, 11:55 AM

Rebase on master, quote everything just-in-case

Harbormaster completed remote builds in B13529: Diff 18543.Nov 17 2022, 12:09 PM
Closed by commit rCOMM7413dab98cda: [Nix] Default value of ANDROID_HOME (authored by • jon). · Explain WhyNov 18 2022, 2:10 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM7413dab98cda: [Nix] Default value of ANDROID_HOME.

Revision Contents
Changeset List

PathSize
scripts/
16 lines

Diff 18543

View Options

scripts/source_development_defaults.sh

Loading...