[keyserver] add index to target_message column of messages table
AbandonedPublic
Actions

Authored by ginsu on Nov 17 2022, 9:23 AM.

Details

Reviewers

atul
rohan

Summary

Add index to target_message column of messages table. This is to better optimize how we will be fetching reaction messages for a certain message

Depends on D5658
Linear Task: ENG-2265

Test Plan

Ran the migration, and tested the stack locally in my evironment to make sure everything still runs as expected/nothing crashes.

Diff Detail

Repository

rCOMM Comm

Branch

eng-2265 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 17 2022, 9:23 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptNov 17 2022, 9:23 AM

ginsu added reviewers: atul, rohan.Nov 17 2022, 9:23 AM

Harbormaster completed remote builds in B13521: Diff 18530.Nov 17 2022, 9:37 AM

ginsu requested review of this revision.Nov 17 2022, 9:37 AM

Looks good!

This revision is now accepted and ready to land.Nov 17 2022, 9:42 AM

What diff introduces the target_message column? I don't see a stack here

@ashoat D5658, just updated the summary to make it a stack

Seems like it would be more simple to have a single migration instead of two

In D5665#168223, @ashoat wrote:

Seems like it would be more simple to have a single migration instead of two

Okay that's a good idea, I will combine the two in the first diff

abandoning because D5658 now handles this migration

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

migration-config.js

11 lines

setup-db.js

3 lines

Diff 18530

View Options

keyserver/src/database/migration-config.js