[lib] Introduce newThread helper to message-reducer.js
ClosedPublic
Actions

Authored by ashoat on Nov 18 2022, 6:13 AM.

Details

Reviewers

atul
tomek

Commits

rCOMM10dae0d8774f: [lib] Introduce newThread helper to message-reducer.js

Summary

This should be a no-op. The only change is that we will have slightly different pruning times, but that should not be significant.

Test Plan

Flow, and also the other testing I've done for the stack

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/androidNotifIssue

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 18 2022, 6:13 AM

ashoat added a parent revision: D5669: [lib] Populate messageStore.threads from threadInfos before setMessageStoreMessages.Nov 18 2022, 6:18 AM

ashoat added a child revision: D5671: [lib] Ensure messageStore.threads entry for each message from SQLite.

Harbormaster completed remote builds in B13549: Diff 18568.Nov 18 2022, 6:27 AM

ashoat requested review of this revision.Nov 18 2022, 6:27 AM

atul accepted this revision.Nov 21 2022, 10:31 AM

atul added inline comments.

lib/reducers/message-reducer.js
133	Ah so the reason we're defining a function instead of an object that we "spread" later is because `Date.now()` is "dynamic"

This revision is now accepted and ready to land.Nov 21 2022, 10:31 AM

ashoat added inline comments.Nov 21 2022, 11:31 AM

lib/reducers/message-reducer.js
133	Yes

Closed by commit rCOMM10dae0d8774f: [lib] Introduce newThread helper to message-reducer.js (authored by ashoat). · Explain WhyNov 21 2022, 2:30 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM10dae0d8774f: [lib] Introduce newThread helper to message-reducer.js.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

29 lines

Diff 18568

View Options

lib/reducers/message-reducer.js

[lib] Introduce newThread helper to message-reducer.jsClosedPublicActions