Page MenuHomePhabricator
Differential D5687

[Android] Use shared proto cmake project
AbandonedPublicDraft
Actions

Authored by • jon on Nov 18 2022, 2:09 PM.
Tags
None
Referenced Files
F3509212: D5687.diff
Sat, Dec 21, 2:29 AM
Unknown Object (File)
Thu, Dec 19, 8:16 PM
Unknown Object (File)
Thu, Dec 19, 8:16 PM
Unknown Object (File)
Thu, Dec 19, 8:16 PM
Unknown Object (File)
Thu, Dec 19, 8:16 PM
Unknown Object (File)
Thu, Dec 19, 8:16 PM
Unknown Object (File)
Thu, Dec 19, 8:14 PM
Unknown Object (File)
Sun, Dec 8, 1:47 PM
View All Files
Subscribers
ashoat

Details

Reviewers
atul
varun
tomek
• max
Summary

Use cmake project from shared/protos directory. This is
an initial step in removing GLOB RECURSE usage in app/CMakeLists.txt.

This is to show that the cmake logic from native/cpp and shared/protos
can be used in the android build.

Part of https://linear.app/comm/issue/ENG-776

Depends on D5686

Test Plan

Android gate passes

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/android-cmake-compat (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Nov 18 2022, 2:09 PM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 18 2022, 2:09 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 18 2022, 2:10 PM
Harbormaster failed remote builds in B13579: Diff 18599!
• jon updated this revision to Diff 18602.Nov 18 2022, 2:14 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 18 2022, 2:26 PM
Harbormaster failed remote builds in B13581: Diff 18602!
• jon updated this revision to Diff 18605.Nov 18 2022, 2:39 PM

Ensure protos/CMakeLists.txt doesn't require grpc

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 18 2022, 2:52 PM
Harbormaster failed remote builds in B13584: Diff 18605!
• jon updated this revision to Diff 18890.Nov 28 2022, 10:06 AM

Rebase on changes

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 28 2022, 10:19 AM
Harbormaster failed remote builds in B13799: Diff 18890!
ashoat added a comment.Nov 29 2022, 2:09 PM

Should we abandon this now that gRPC-C++ isn't used from the Android build following D5706?

• jon added a comment.Nov 30 2022, 7:17 PM

Should we abandon this now that gRPC-C++ isn't used from the Android build following D5706?

Note, the tunnelbroker build is now building against protobuf 3.12

• jon abandoned this revision.Nov 30 2022, 7:17 PM

Revision Contents
Changeset List

PathSize
native/
android/
app/
10 lines
shared/
protos/
4 lines

Diff 18890

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

shared/protos/CMakeLists.txt

Loading...