[Nix] Set TMP to stable path
ClosedPublic
Actions

Authored by • jon on Nov 28 2022, 12:33 PM.

Tags

None

Referenced Files

	F3247894: D5745.diff
	Fri, Nov 15, 7:28 AM

	Unknown Object (File)
	Wed, Nov 6, 7:05 PM

	Unknown Object (File)
	Wed, Nov 6, 7:05 PM

	Unknown Object (File)
	Mon, Nov 4, 3:49 PM

	Unknown Object (File)
	Mon, Nov 4, 3:49 PM

	Unknown Object (File)
	Tue, Oct 22, 11:52 AM

	Unknown Object (File)
	Tue, Oct 22, 11:52 AM

	Unknown Object (File)
	Tue, Oct 22, 11:44 AM

Subscribers

Details

Reviewers

• adar
varun
ashoat

Commits

rCOMMe16ce1f896a6: [Nix] Set TMP to stable path

Summary

mysql2 (or some dependent) node package assumes that the temporary
directory will have a stable path prefix, so we'll provide it with one.

https://linear.app/comm/issue/ENG-2366

Test Plan

nix develop

cd keyserver
yarn dev

# Not actually sure how to trigger previous failure

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Nov 28 2022, 12:33 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 28 2022, 12:33 PM

Harbormaster completed remote builds in B13806: Diff 18897.Nov 28 2022, 12:47 PM

• jon requested review of this revision.Nov 28 2022, 12:47 PM

Sketchy test plan but not sure how else to test. Seems like it's a clear will

This revision is now accepted and ready to land.Nov 28 2022, 2:15 PM

Closed by commit rCOMMe16ce1f896a6: [Nix] Set TMP to stable path (authored by • jon). · Explain WhyNov 28 2022, 2:31 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMe16ce1f896a6: [Nix] Set TMP to stable path.

Revision Contents
Changeset List

Path

Size

scripts/

source_development_defaults.sh

10 lines

Diff 18898

View Options

scripts/source_development_defaults.sh

[Nix] Set TMP to stable pathClosedPublicActions