Paths

Table of Contentst

[web] Remove friend request suggestion in sidebar chats
ClosedPublic
Actions

Authored by • adar on Nov 29 2022, 2:28 PM.

Details

Reviewers

atul
tomek

Commits

rCOMMe1a38bfdcc54: [web] Remove friend request suggestion in sidebar chats

Summary

Linear

previously the RelationshipPrompt component was getting rendered in sidebar chats on web. This diff adds the proper check to prevent this behavior.

Test Plan

Before:

Screen Shot 2022-11-29 at 5.07.41 PM.png (2×5 px, 592 KB)

After:

Screen Shot 2022-11-29 at 5.16.19 PM.png (2×5 px, 571 KB)

Screen Shot 2022-11-29 at 5.16.23 PM.png (2×5 px, 582 KB)

Test ensuring that relationship prompt still shows on Personal threads

Screen Shot 2022-11-30 at 2.00.50 PM.png (2×5 px, 606 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• adar created this revision.Nov 29 2022, 2:28 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 29 2022, 2:28 PM

• adar edited the summary of this revision. (Show Details)Nov 29 2022, 2:31 PM

• adar edited the test plan for this revision. (Show Details)

• adar added reviewers: atul, tomek.

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 29 2022, 2:38 PM

Harbormaster failed remote builds in B13858: Diff 18981!

• adar added inline comments.Nov 29 2022, 2:43 PM

web/chat/chat-message-list.react.js
193 ↗	(On Diff #18981)	here i only initialized to null to achieve consistency with native, if that's at all important

Harbormaster completed remote builds in B13858: Diff 18981.Nov 29 2022, 2:54 PM

• adar requested review of this revision.Nov 29 2022, 2:54 PM

Regarding the test plan, you also have to check if the prompt is still displayed in PERSONAL threads.

web/chat/chat-message-list.react.js
193 ↗	(On Diff #18981)	It's ok both ways

This revision is now accepted and ready to land.Nov 30 2022, 5:43 AM

In D5761#172111, @tomek wrote:

Regarding the test plan, you also have to check if the prompt is still displayed in PERSONAL threads.

ah yes, updated the test plan.

• adar edited the test plan for this revision. (Show Details)Nov 30 2022, 11:05 AM

Closed by commit rCOMMe1a38bfdcc54: [web] Remove friend request suggestion in sidebar chats (authored by • adar). · Explain WhyNov 30 2022, 11:16 AM

This revision was automatically updated to reflect the committed changes.

• adar added a commit: rCOMMe1a38bfdcc54: [web] Remove friend request suggestion in sidebar chats.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-message-list.react.js

6 lines

Diff 19027

View Options

web/chat/chat-message-list.react.js

[web] Remove friend request suggestion in sidebar chatsClosedPublicActions