Page MenuHomePhabricator
Differential D5773

Refactor getAllThreads{Sync}. Bring db threads parsing into separate function
ClosedPublic
Actions

Authored by marcin on Nov 30 2022, 10:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 6:24 PM
Unknown Object (File)
Fri, Nov 22, 6:45 AM
Unknown Object (File)
Fri, Nov 22, 6:45 AM
Unknown Object (File)
Fri, Nov 22, 6:45 AM
Unknown Object (File)
Fri, Nov 22, 6:45 AM
Unknown Object (File)
Fri, Nov 22, 6:39 AM
Unknown Object (File)
Nov 18 2024, 7:41 PM
Unknown Object (File)
Nov 18 2024, 7:24 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
• jon
Commits
rCOMM2f22ef61ffcf: Refactor getAllThreads{Sync}. Bring db threads parsing into separate function
Summary

This differential brings db threads parsing into separate function. It will be usefull when we implement one JSI call to fetch all SQLite data.

Test Plan

Launch the app, kill the app. Launch it again with flipper. Ensure threads are in the payload of SET_CLIENT_DB_STORE action.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Nov 30 2022, 10:48 AM
Herald added a reviewer: • jon. · View Herald TranscriptNov 30 2022, 10:48 AM
Herald added a subscriber: ashoat. · View Herald Transcript
marcin added a parent revision: D5772: Refactor getAllMessages{Sync}. Bring db messages parsing to separate function.Nov 30 2022, 10:49 AM
Harbormaster completed remote builds in B13887: Diff 19020.Nov 30 2022, 10:58 AM
marcin requested review of this revision.Nov 30 2022, 10:58 AM
marcin added a child revision: D5774: Implement bulk JSI call te retrieve all SQLite data.Nov 30 2022, 11:29 AM
tomek accepted this revision.Dec 1 2022, 6:13 AM
This revision is now accepted and ready to land.Dec 1 2022, 6:13 AM
marcin updated this revision to Diff 19096.Dec 2 2022, 12:43 AM

Rebase before landing

Harbormaster completed remote builds in B13936: Diff 19096.Dec 2 2022, 12:55 AM
Closed by commit rCOMM2f22ef61ffcf: Refactor getAllThreads{Sync}. Bring db threads parsing into separate function (authored by marcin). · Explain WhyDec 2 2022, 1:06 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM2f22ef61ffcf: Refactor getAllThreads{Sync}. Bring db threads parsing into separate function.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
173 lines

Diff 19101

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...