[native] 2/N Disable 'Delete' button on delete acconut modal when password input is empty
ClosedPublic
Actions

Authored by • adar on Nov 30 2022, 12:40 PM.

Details

Reviewers

atul
rohan
ginsu

Commits

rCOMMae55af8a7cce: [native] 2/N Disable 'Delete' button on delete acconut modal when password…

Summary

This diff covers the native side of disabling the "Delete account" button when a user has yet to input anything.
Curiously, the disabled feature on native appears to not gray-out the button but only not allow users to click it (see test video)
ENG-2014

Test Plan

Verify that the button is disabled (unclickable) when text input is empty.

https://www.loom.com/share/b89ddf1249eb4b05aa56fee974a1552b

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• adar created this revision.Nov 30 2022, 12:40 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 30 2022, 12:40 PM

Harbormaster completed remote builds in B13897: Diff 19037.Nov 30 2022, 12:50 PM

• adar requested review of this revision.Nov 30 2022, 12:50 PM

You need a test plan and you need reviewers. Please don't submit diffs in this state

In D5778#172487, @ashoat wrote:

You need a test plan and you need reviewers. Please don't submit diffs in this state

totally meant to keep this as a draft! my bad !!!

• adar edited the summary of this revision. (Show Details)Nov 30 2022, 7:18 PM

• adar edited the test plan for this revision. (Show Details)

• adar added a reviewer: atul.

• adar edited the summary of this revision. (Show Details)

atul added reviewers: rohan, ginsu.Dec 1 2022, 2:08 PM

Curiously, the disabled feature on native appears to not gray-out the button but only not allow users to click it

I'm not 100% on this, but I worked on the same kind of thing for a different area on native (https://phab.comm.dev/D5320), and I think the reason for that is we're actually rendering Button from a custom component, not from react-native so the expected behavior might be different. Probably good to double check this though since I might be wrong here

This revision is now accepted and ready to land.Dec 1 2022, 2:15 PM

atul accepted this revision.Dec 1 2022, 2:44 PM

Closed by commit rCOMMae55af8a7cce: [native] 2/N Disable 'Delete' button on delete acconut modal when password… (authored by • adar). · Explain WhyDec 5 2022, 10:32 AM

This revision was automatically updated to reflect the committed changes.

• adar added a commit: rCOMMae55af8a7cce: [native] 2/N Disable 'Delete' button on delete acconut modal when password….