Page MenuHomePhabricator

[native] 2/N Disable 'Delete' button on delete acconut modal when password input is empty
ClosedPublic

Authored by adar on Nov 30 2022, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 10:16 AM
Unknown Object (File)
Tue, Jun 11, 7:46 AM
Unknown Object (File)
Mon, Jun 10, 3:22 AM
Unknown Object (File)
Sun, Jun 9, 9:21 PM
Unknown Object (File)
Thu, Jun 6, 12:58 PM
Unknown Object (File)
Thu, May 30, 9:18 PM
Unknown Object (File)
Thu, May 30, 9:18 PM
Unknown Object (File)
Fri, May 24, 9:44 AM
Subscribers

Details

Summary

This diff covers the native side of disabling the "Delete account" button when a user has yet to input anything.
Curiously, the disabled feature on native appears to not gray-out the button but only not allow users to click it (see test video)
ENG-2014

Test Plan

Verify that the button is disabled (unclickable) when text input is empty.

https://www.loom.com/share/b89ddf1249eb4b05aa56fee974a1552b

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You need a test plan and you need reviewers. Please don't submit diffs in this state

You need a test plan and you need reviewers. Please don't submit diffs in this state

totally meant to keep this as a draft! my bad !!!

adar edited the test plan for this revision. (Show Details)
adar added a reviewer: atul.
adar edited the summary of this revision. (Show Details)

Curiously, the disabled feature on native appears to not gray-out the button but only not allow users to click it

I'm not 100% on this, but I worked on the same kind of thing for a different area on native (https://phab.comm.dev/D5320), and I think the reason for that is we're actually rendering Button from a custom component, not from react-native so the expected behavior might be different. Probably good to double check this though since I might be wrong here

This revision is now accepted and ready to land.Dec 1 2022, 2:15 PM